Skip to content

Commit

Permalink
fix: Remove unnecessary google cloud steps & upgrade docker action ve…
Browse files Browse the repository at this point in the history
…rsions (#4925)

remove unecessary google cloud steps & upgrade docker action versions

Signed-off-by: Tommy Hughes <[email protected]>
  • Loading branch information
tchughesiv authored Jan 15, 2025
1 parent 13c7267 commit 32aaf9a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 18 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/java_master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Build image
run: make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
- name: Login to Quay.io
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
registry: quay.io
username: ${{ secrets.QUAYIO_CI_USERNAME }}
Expand Down
26 changes: 9 additions & 17 deletions .github/workflows/master_only.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,39 +96,31 @@ jobs:
matrix:
component: [ feature-server-dev, feature-transformation-server, feast-operator ]
env:
MAVEN_CACHE: gs://feast-templocation-kf-feast/.m2.2020-08-19.tar
REGISTRY: quay.io/feastdev-ci
IMAGE: ${{ matrix.component }}
steps:
- uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
uses: docker/setup-buildx-action@v3
with:
install: true
- name: Login to Quay.io
uses: docker/login-action@v1
uses: docker/login-action@v3
with:
registry: quay.io
username: ${{ secrets.QUAYIO_CI_USERNAME }}
password: ${{ secrets.QUAYIO_CI_TOKEN }}
- name: Authenticate to Google Cloud
uses: 'google-github-actions/auth@v1'
with:
credentials_json: '${{ secrets.GCP_SA_KEY }}'
- name: Set up gcloud SDK
uses: google-github-actions/setup-gcloud@v1
with:
project_id: ${{ secrets.GCP_PROJECT_ID }}
- name: Use gcloud CLI
run: gcloud info
- run: gcloud auth configure-docker --quiet
- name: Build image
run: |
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
- name: Push image
run: |
make push-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${GITHUB_SHA}
docker tag ${REGISTRY}/${{ matrix.component }}:${GITHUB_SHA} ${REGISTRY}/${{ matrix.component }}:develop
docker push ${REGISTRY}/${{ matrix.component }}:develop
if [[ ${{ matrix.component }} == "feature-server-dev" ]]; then
echo "IMAGE=feature-server" >> $GITHUB_ENV
fi
docker tag ${REGISTRY}/${IMAGE}:${GITHUB_SHA} ${REGISTRY}/${IMAGE}:develop
docker push ${REGISTRY}/${IMAGE}:develop

0 comments on commit 32aaf9a

Please sign in to comment.