Skip to content

Commit

Permalink
fix publish, versions issue
Browse files Browse the repository at this point in the history
Signed-off-by: Tommy Hughes <[email protected]>
  • Loading branch information
tchughesiv committed Jan 21, 2025
1 parent c8378a3 commit eb18984
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 15 deletions.
30 changes: 16 additions & 14 deletions .github/workflows/build_wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ name: build wheels
# Devs should check out their fork, add a tag to the last master commit on their fork, and run the release off of their fork on the added tag to ensure wheels will be built correctly.
on:
workflow_dispatch:
tags:
- 'v*.*.*'
inputs:
release_version:
description: 'The release version to use (e.g., v1.2.3)'
Expand Down Expand Up @@ -39,12 +37,6 @@ on:
type: string

jobs:
get-version:
uses: ./.github/workflows/get_semantic_release_version.yml
with:
custom_version: ${{ github.event.inputs.release_version }}
token: ${{ github.event.inputs.token }}

build-python-wheel:
name: Build wheels
runs-on: ubuntu-latest
Expand Down Expand Up @@ -111,30 +103,34 @@ jobs:
build-docker-images:
name: Build Docker images
runs-on: ubuntu-latest
needs: get-version
strategy:
matrix:
component: [ feature-server, feature-server-java, feature-transformation-server, feast-operator ]
env:
REGISTRY: feastdev
steps:
- id: get-version
uses: ./.github/workflows/get_semantic_release_version.yml
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}
- uses: actions/checkout@v4
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
- name: Build image
run: |
VERSION_WITHOUT_PREFIX=${{ needs.get-version.outputs.version_without_prefix }}
RELEASE_VERSION=${{ needs.get-version.outputs.release_version }}
HIGHEST_SEMVER_TAG=${{ needs.get-version.outputs.highest_semver_tag }}
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
HIGHEST_SEMVER_TAG: ${{ steps.get-version.outputs.highest_semver_tag }}
RELEASE_VERSION=${{ steps.get-version.outputs.release_version }}
echo "Building docker image for ${{ matrix.component }} with version $VERSION_WITHOUT_PREFIX and release version $RELEASE_VERSION"
make build-${{ matrix.component }}-docker REGISTRY=${REGISTRY} VERSION=${VERSION_WITHOUT_PREFIX}
verify-python-wheels:
name: Verify Python wheels
runs-on: ${{ matrix.os }}
needs: [ build-python-wheel, build-source-distribution, get-version ]
needs: [ build-python-wheel, build-source-distribution ]
strategy:
matrix:
os: [ ubuntu-latest, macos-13 ]
Expand All @@ -153,8 +149,12 @@ jobs:
else
echo "Succeeded!"
fi
VERSION_WITHOUT_PREFIX: ${{ needs.get-version.outputs.version_without_prefix }}
steps:
- id: get-version
uses: ./.github/workflows/get_semantic_release_version.yml
with:
custom_version: ${{ github.event.inputs.custom_version }}
token: ${{ github.event.inputs.token }}
- name: Setup Python
id: setup-python
uses: actions/setup-python@v5
Expand Down Expand Up @@ -185,6 +185,8 @@ jobs:
run: pip install dist/*tar.gz
# Validate that the feast version installed is not development and is the correct version of the tag we ran it off of.
- name: Validate Feast Version
env:
VERSION_WITHOUT_PREFIX: ${{ steps.get-version.outputs.version_without_prefix }}
run: |
feast version
if ! VERSION_OUTPUT=$(feast version); then
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/publish_images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,3 @@ jobs:
docker tag feastdev/${{ matrix.component }}:${VERSION_WITHOUT_PREFIX} feastdev/${{ matrix.component }}:latest
docker push feastdev/${{ matrix.component }}:latest
fi

0 comments on commit eb18984

Please sign in to comment.