-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updating dependencies so that feast can be run on 3.11. #3985
Conversation
Signed-off-by: Lokesh Rangineni <[email protected]>
@lokeshrangineni thanks for giving this another look! PTAL at the linter output, but I'm going to go ahead and approve tests so we can get an idea how integration results look 👍 |
copying out the two error lines from lint job so we don't have to keep pulling context back up
|
setup.py
Outdated
@@ -187,7 +187,7 @@ | |||
"types-setuptools", | |||
"types-tabulate", | |||
"virtualenv<20.24.2", | |||
"pandas>=1.4.3,<2; python_version < '3.9'", | |||
"pandas>=1.4.3,<2; python_version <= '3.11'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get this change. This rule was added during #3957 specifically to handle the issue with the latest pandas version for 3.8 which contained a bug in pandas.testing
. If we're dropping 3.8 from ci, this rule can be removed.
Are we dropping ci, but keeping support? shouldn't this PR change |
@tokoko please keep 'em coming, I'm just trying to work thru the required check, but I'm missing historical context. Appreciate the good feedback! |
@jeremyary no problem :) I think we should definitely be running |
Thank you for the context. I am going to update the PR with the information you provided. |
thanks again. A related thread's been going through our last couple of comm calls, though we didn't get into the procedural side. Without moving on from 3.8 we're stuck in a bit of a hard place around other dependencies that will soon stop supporting 3.8. I'm down for a collective rehashing via Slack if warranted, though cc @lokeshrangineni @etirelli @franciscojavierarceo |
…he upgrade. These classes ManualInputConfig and ManualOutputConfig have been removed from the new versions. hope this fixes the lint errors. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
…tly build to the lowest python version we are planning to support. Updating the REQUIRES_PYTHON to 3.9 as well. Signed-off-by: Lokesh Rangineni <[email protected]> Signed-off-by: Lokesh Rangineni <[email protected]>
I have closed the this PR and opened the PR to test if the unit test cases job to run using python 3.8 have been removed or not. Please find the new PR here - #3993 |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #