Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed unneeded install line #4782

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

dandawg
Copy link
Contributor

@dandawg dandawg commented Nov 21, 2024

What this PR does / why we need it:

This PR removes the command pip install Pygments -q (and a supporting comment) from the quickstart.ipynb notebook. This install command is not needed because Pygments is a feast dependency that is installed with feast. Removing the extra install line simplifies the notebook and makes it easier to get started quickly, as it makes the cell run faster.

Which issue(s) this PR fixes:

Misc

To test that the notebook still works you can:

  1. Create a new venv and install jupyter (you need this to run the notebook):
cd examples/quickstart
python -m venv temp-venv
pip install jupyter
  1. Run the quickstart.ipynb from this PR (with the Pygments import statement removed). It should run successfully.
jupyter execute quickstart.ipynb

Note that the notebook itself installs feast latest. You can verify that pygments is an explicit dependency of feast with:

% pip show Pygments | grep Required-by

# Output
Required-by: feast, ipython, jupyter-console, nbconvert

@dandawg dandawg requested a review from a team as a code owner November 21, 2024 20:42
@franciscojavierarceo franciscojavierarceo merged commit 85d00bb into feast-dev:master Nov 22, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants