fix: Missing operator in and notIn for string attribute and value…

… s condition (#56)
featurevisor · Nov 10, 2023 · 891910f · 891910f
1 parent 5e19a20
commit 891910f
Show file tree

Hide file tree

Showing 2 changed files with 75 additions and 0 deletions.
diff --git a/Sources/FeaturevisorSDK/Conditions.swift b/Sources/FeaturevisorSDK/Conditions.swift
@@ -95,6 +95,17 @@ public func conditionIsMatched(condition: PlainCondition, context: Context) -> B
                     return false
             }
 
+        // string, [strings]
+        case (.string(let valueInAttribute), .array(let valuesInCondition)):
+            switch op {
+                case .in:
+                    return valuesInCondition.contains(valueInAttribute)
+                case .notIn:
+                    return !valuesInCondition.contains(valueInAttribute)
+                default:
+                    return false
+            }
+
         // date, string
         case (.date(let valueInAttributes), .string(let valueInCondition)):
             switch op {

diff --git a/Tests/FeaturevisorSDKTests/ConditionsTests.swift b/Tests/FeaturevisorSDKTests/ConditionsTests.swift
@@ -103,6 +103,70 @@ class ConditionsTests: XCTestCase {
         XCTAssertTrue(conditionIsMatched(condition: condition, context: context))
     }
 
+    func testStringInArrayShouldReturnTrue() {
+        //Given
+        let condition = PlainCondition(
+            attribute: "text",
+            operator: .in,
+            value: .array(["test-1", "test-2"])
+        )
+        var context = Context()
+
+        //When
+        context["text"] = .string("test-1")
+
+        //Then
+        XCTAssertTrue(conditionIsMatched(condition: condition, context: context))
+    }
+
+    func testStringInArrayShouldReturnFalse() {
+        //Given
+        let condition = PlainCondition(
+            attribute: "text",
+            operator: .in,
+            value: .array(["test-1", "test-2"])
+        )
+        var context = Context()
+
+        //When
+        context["text"] = .string("test-3")
+
+        //Then
+        XCTAssertFalse(conditionIsMatched(condition: condition, context: context))
+    }
+
+    func testStringNotInArrayShouldReturnTrue() {
+        //Given
+        let condition = PlainCondition(
+            attribute: "text",
+            operator: .notIn,
+            value: .array(["test-1", "test-2"])
+        )
+        var context = Context()
+
+        //When
+        context["text"] = .string("test-3")
+
+        //Then
+        XCTAssertTrue(conditionIsMatched(condition: condition, context: context))
+    }
+
+    func testStringNotInArrayShouldReturnFalse() {
+        //Given
+        let condition = PlainCondition(
+            attribute: "text",
+            operator: .notIn,
+            value: .array(["test-1", "test-2"])
+        )
+        var context = Context()
+
+        //When
+        context["text"] = .string("test-2")
+
+        //Then
+        XCTAssertFalse(conditionIsMatched(condition: condition, context: context))
+    }
+
     func testDateBefore() {
 
         //Given