-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: wrong negation under allGroupSegmentsAreMatched for 'not' operator
- Loading branch information
Showing
2 changed files
with
116 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
Tests/FeaturevisorSDKTests/InstanceTests+Segments.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| import Foundation | ||
| import XCTest | ||
|
|
||
| @testable import FeaturevisorSDK | ||
| @testable import FeaturevisorTypes | ||
|
|
||
| extension FeaturevisorInstanceTests { | ||
|
|
||
| func testShouldMatchWithMultipleConditionsInsideNOT() { | ||
|
|
||
| // GIVEN | ||
| var options: InstanceOptions = .default | ||
| options.datafile = DatafileContent( | ||
| schemaVersion: "1", | ||
| revision: "1.0", | ||
| attributes: [ | ||
| .init(key: "userId", type: "string", capture: true), | ||
| .init(key: "country", type: "string"), | ||
| .init(key: "device_os", type: "string"), | ||
| ], | ||
| segments: [ | ||
| .init( | ||
| key: "CountryDE", | ||
| conditions: .plain( | ||
| .init(attribute: "country", operator: .equals, value: .string("de")) | ||
| ) | ||
| ), | ||
| .init( | ||
| key: "CountryAT", | ||
| conditions: .plain( | ||
| .init(attribute: "country", operator: .equals, value: .string("at")) | ||
| ) | ||
| ), | ||
| .init( | ||
| key: "CountryCH", | ||
| conditions: .plain( | ||
| .init(attribute: "country", operator: .equals, value: .string("ch")) | ||
| ) | ||
| ), | ||
| .init( | ||
| key: "OsIOS", | ||
| conditions: .plain( | ||
| .init( | ||
| attribute: "device_os", | ||
| operator: .in, | ||
| value: .array(["iOS", "iPadOS"]) | ||
| ) | ||
| ) | ||
| ), | ||
| ], | ||
|
|
||
| features: [ | ||
| .init( | ||
| key: "feature_test_key", | ||
| bucketBy: .single("userId"), | ||
| variablesSchema: [], | ||
| traffic: [ | ||
| .init( | ||
| key: "1", | ||
| segments: .multiple([ | ||
| .and( | ||
| .init(and: [ | ||
| .plain("OsIOS"), | ||
| .not( | ||
| .init(not: [ | ||
| .plain("CountryAT"), | ||
| .plain("CountryDE"), | ||
| .plain("CountryCH"), | ||
| ]) | ||
| ), | ||
| ]) | ||
| ) | ||
| ]), | ||
| percentage: 100000, | ||
| allocation: [], | ||
| variables: [:] | ||
| ), | ||
| .init( | ||
| key: "2", | ||
| segments: .plain("*"), | ||
| percentage: 0, | ||
| allocation: [] | ||
| ), | ||
| ] | ||
| ) | ||
| ] | ||
| ) | ||
|
|
||
| let sdk = try! createInstance(options: options) | ||
|
|
||
| // WHEN | ||
| // THEN | ||
| XCTAssertFalse( | ||
| sdk.isEnabled( | ||
| featureKey: "feature_test_key", | ||
| context: [ | ||
| "device_os": AttributeValue.string("iOS"), | ||
| "country": AttributeValue.string("de"), | ||
| ] | ||
| ) | ||
| ) | ||
|
|
||
| XCTAssertTrue( | ||
| sdk.isEnabled( | ||
| featureKey: "feature_test_key", | ||
| context: [ | ||
| "device_os": AttributeValue.string("iOS"), | ||
| "country": AttributeValue.string("pl"), | ||
| ] | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| } |