fix: wrong parsing datafile for segments if defined as pure string #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like: "segments": "PlatformWeb"
polok
commented
Jan 9, 2024
Comment on lines
+35
to
+40
| guard | ||
| let _ = try? JSONSerialization.jsonObject(with: data, options: .allowFragments) | ||
| else { | ||
| return .plain(stringifiedGroupSegment) | ||
| } | ||
|
|
There was a problem hiding this comment.
These lines are the fix
PatrykPiwowarczyk
approved these changes
Jan 9, 2024
FranciszekCzana
approved these changes
Jan 9, 2024
fahad19
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Targeting your audience is one of the most important things when rolling out features. You can do that with segments - https://featurevisor.com/docs/features/#segments
The issue
The segment can be defined like
"segments": "SEGMENT_NAME"what was causing an issue with datafile parsing.The fix
Such pure segment string definition is being mapped to
GroupSegment.plain("SEGMENT_NAME")