fix: wrong negation under allGroupSegmentsAreMatched for 'not' operator

[polok]

Background

Conditions can also be combined using not operator.

# ...
conditions:
  not:
    - attribute: country
      operator: equals
      value: us

Issue

When using not operator all segment groups have to match. Moreover, if at least one of the segment doesn't match at the end we get false positive.

Where to fix?

In this line:

featurevisor-swift/Sources/FeaturevisorSDK/Instance+Segments.swift

Line 75 in 6e6b411

return !notGroupSegment.not.allSatisfy { groupSegment in

before:

case .not(let notGroupSegment):
return !notGroupSegment.not.allSatisfy { groupSegment in
    allGroupSegmentsAreMatched(
            groupSegments: groupSegment,
            context: context,
            datafileReader: datafileReader

after:

case .not(let notGroupSegment):
return notGroupSegment.not.allSatisfy { groupSegment in
    !allGroupSegmentsAreMatched(
            groupSegments: groupSegment,
            context: context,
            datafileReader: datafileReader
    )
}

[fahad19]

this is the JS equivalent:

https://github.com/featurevisor/featurevisor/blob/c6ea5767c24263a215a4134beef16831467a8c49/packages/sdk/src/segments.ts#L41-L46