Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant 'equatable' for VariableValue under tests #69

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor: remove redundant 'equatable' for VariableValue under tests #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions Tests/FeaturevisorTypesTests/Extensions/Types+Equatable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,26 +73,3 @@ extension GroupSegment: Equatable {
}
}
}

extension VariableValue: Equatable {
public static func == (lhs: VariableValue, rhs: VariableValue) -> Bool {
switch (lhs, rhs) {
case (.string(let lhsString), .string(let rhsString)):
return lhsString == rhsString
case (.double(let lhsDouble), .double(let rhsDouble)):
return lhsDouble == rhsDouble
case (.integer(let lhsInteger), .integer(let rhsInteger)):
return lhsInteger == rhsInteger
case (.array(let lhsArray), .array(let rhsArray)):
return lhsArray == rhsArray
case (.object(let lhsObject), .object(let rhsObject)):
return lhsObject == rhsObject
case (.json(let lhsJson), .json(let rhsJson)):
return lhsJson == rhsJson
case (.boolean(let lhsBoolean), .boolean(let rhsBoolean)):
return lhsBoolean == rhsBoolean
default:
return false
}
}
}
Loading