Update resource-file path #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, forgot to link the actual issue, see here for more information: |
|
This works for me. @zbarbuto you're suggesting a new major version of cordova-plugin-fcm because of this fix? Couldn't it be resolved by setting a minimum version of cordova-ios in plugin.xml? |
|
Yes, that works also. |
|
This works for me too! |
1 similar comment
|
This works for me too! |
|
Have bumped the minimum cordova-ios version as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]Seems to change the way thetargetattribute works inresource-file. As a result, if I install the plugin as-is myGoogleService-Info.plistfile ends up inplatforms/ios/<AppName>/Resources/Resources/GoogleService-Info.plistinstead ofplatforms/ios/<AppName>/Resources/GoogleService-Info.plist.This PR fixes the problem resulting in the latter.
Suggested semver major since it would potentially break on older versions of
cordova-ios(haven't tested)