Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin for android latest and add var in strings.xml #461

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

djodjonx
Copy link

I have fix pluflin issue with the path of file strings in android latest, check the path for old and new android platform.

I have changed the regex for replace android app-id and api-key who's not add in file, the regex replace an item who's not exist. Now, all balises are create.

@bastiendonjon
Copy link

+1

@giannisdaras
Copy link

Great job!

@adrm
Copy link

adrm commented Jun 1, 2018

I am using your branch with the latest version of cordova android, it works great! It's a shame this library seems unmantained lately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants