Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Modal Consistency #611

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Improve Modal Consistency #611

merged 4 commits into from
Feb 10, 2025

Conversation

tsmith123
Copy link
Collaborator

@tsmith123 tsmith123 commented Feb 5, 2025

This PR makes the modals on the Home page more consistent.

Also, due to Gateway UI not being production ready, it offers a way to prevent new Gateways being added. (This is only a suggestion so please let me know if this approach is too heavy handed and you prefer a different approach).

  • Move action buttons on add and edit service modals to the right hand side
  • Make spacing consistent across add, edit and delete service modals
  • Adds translation for new error message
  • Adds translation for existing error message

New Delete Service Modal
Screenshot 2025-02-05 at 19 59 51

New Edit Service Modal
Screenshot 2025-02-05 at 19 41 35

New Add Service Modal
Screenshot 2025-02-05 at 19 41 54

Add Service Modal (with error message)
Screenshot 2025-02-05 at 20 02 13

@tsmith123 tsmith123 requested a review from a team as a code owner February 5, 2025 20:04
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 8:37am

@elsirion
Copy link
Contributor

elsirion commented Feb 5, 2025

Sounds good enough for now, let's work on GW UI once we got a stable release again

@joschisan
Copy link

joschisan commented Feb 6, 2025

Also, due to Gateway UI not being production ready, it offers a way to prevent new Gateways being added. (This is only a suggestion so please let me know if this approach is too heavy handed and you prefer a different approach).

@elsirion @tsmith123 I think we should consider to deprecate the gateway UI for now and eventually remove it due to the following reasons:

  • gateway operators are technical and can just use cli, @m1sterc001guy uses it to manage our gateway and it works well.
  • gateway changes quicker and is therefore harder to maintain
  • gateway has more functionality that we would have to display, lnv2 will also add channel management etc. at the same time the guardian UI mostly needs to display information.

Therefore the value / cost ratio seems to differ significantly for gateway and guardian UI.

@elsirion
Copy link
Contributor

elsirion commented Feb 6, 2025

As discussed on the call, in the short term the Guardian UI is more important indeed, but if we want more people to run gateways eventually we need to visualize the complex data associated with them. In that sense a good UI is even more important for Gateways than Guardians, there's just much more information.

I also see community-run Gateways as a crucial component for widespread Fedimint adoption. Professional Gateway providers will always need to take custody of some user funds since they don't have a trust relationship to the federation. Having community members with a trust relationship run Gateways fixes this. We are already working towards that by integrating LDK, which should ultimately allow zero-management Gateways by connecting to an LSP.

@tsmith123
Copy link
Collaborator Author

tsmith123 commented Feb 7, 2025

Thanks for the input. What I will do is restore the original logic re: gateways on this PR to keep it just abut the modals. Then I will create a new PR to prevent a user accessing the Gateway UI as a temporary measure but I will probably tackle it on the password page as this current approach would be bypassed unwittingly by providing the Gateway Url Env Var anwyay.

@tsmith123 tsmith123 changed the title Update Modals (and Prevent New Gateway Creation) Update Modals Feb 7, 2025
@tsmith123 tsmith123 changed the title Update Modals Improve Modal Consistency Feb 7, 2025
Copy link
Member

@alexlwn123 alexlwn123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. LGTM. fyi, if you haven't already, we should update the readme & just scripts to reflect the disabled gateway ui

@alexlwn123 alexlwn123 merged commit 684d1a7 into master Feb 10, 2025
4 checks passed
@alexlwn123 alexlwn123 deleted the tom/prevent-new-gateways branch February 10, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants