-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Modal Consistency #611
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sounds good enough for now, let's work on GW UI once we got a stable release again |
@elsirion @tsmith123 I think we should consider to deprecate the gateway UI for now and eventually remove it due to the following reasons:
Therefore the value / cost ratio seems to differ significantly for gateway and guardian UI. |
As discussed on the call, in the short term the Guardian UI is more important indeed, but if we want more people to run gateways eventually we need to visualize the complex data associated with them. In that sense a good UI is even more important for Gateways than Guardians, there's just much more information. I also see community-run Gateways as a crucial component for widespread Fedimint adoption. Professional Gateway providers will always need to take custody of some user funds since they don't have a trust relationship to the federation. Having community members with a trust relationship run Gateways fixes this. We are already working towards that by integrating LDK, which should ultimately allow zero-management Gateways by connecting to an LSP. |
Thanks for the input. What I will do is restore the original logic re: gateways on this PR to keep it just abut the modals. Then I will create a new PR to prevent a user accessing the Gateway UI as a temporary measure but I will probably tackle it on the password page as this current approach would be bypassed unwittingly by providing the Gateway Url Env Var anwyay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. LGTM. fyi, if you haven't already, we should update the readme & just scripts to reflect the disabled gateway ui
This PR makes the modals on the Home page more consistent.
Also, due to Gateway UI not being production ready, it offers a way to prevent new Gateways being added. (This is only a suggestion so please let me know if this approach is too heavy handed and you prefer a different approach).New Delete Service Modal
![Screenshot 2025-02-05 at 19 59 51](https://private-user-images.githubusercontent.com/7639854/410159859-55ff525b-e531-4c2a-9cee-91dcb071fc3c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODAzNTEsIm5iZiI6MTczOTI4MDA1MSwicGF0aCI6Ii83NjM5ODU0LzQxMDE1OTg1OS01NWZmNTI1Yi1lNTMxLTRjMmEtOWNlZS05MWRjYjA3MWZjM2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMyMDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTMzZDViZmVmZGI4MGFhNTIzMmVjOTExMDljMjEwZjhiNWQwYjkyYzFjZjZjMjVjNWE5NzIxYWE5NjYyMDFjYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.ToEBCbObAs0wZRWodB2MIQoMfgQ99n0fVkAddUhR3W4)
New Edit Service Modal
![Screenshot 2025-02-05 at 19 41 35](https://private-user-images.githubusercontent.com/7639854/410159292-bb7a57b8-9292-4f06-8717-471faeec8642.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODAzNTEsIm5iZiI6MTczOTI4MDA1MSwicGF0aCI6Ii83NjM5ODU0LzQxMDE1OTI5Mi1iYjdhNTdiOC05MjkyLTRmMDYtODcxNy00NzFmYWVlYzg2NDIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMyMDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDQyNThkYjc4Yzk0NzgwMDgxYzM2OGNmZTA2MDUzMTQ4MWEzNjBkMmE2YjQ2MzQ3NTk3MjRjNzNjOTg1ZDlkZCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.lsf6PEqFovwwhx0S7f6uIuYBbsevwjPzrxWj-1x58wQ)
New Add Service Modal
![Screenshot 2025-02-05 at 19 41 54](https://private-user-images.githubusercontent.com/7639854/410158849-6afcc7d0-3911-4d5a-8136-cb1e789f433b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODAzNTEsIm5iZiI6MTczOTI4MDA1MSwicGF0aCI6Ii83NjM5ODU0LzQxMDE1ODg0OS02YWZjYzdkMC0zOTExLTRkNWEtODEzNi1jYjFlNzg5ZjQzM2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMyMDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWFlMGQ2NDgwNWYwYzlmNGNhMGU3YmU2NTJmZDJhZWU3MDc0NDQ1MTQ5NTk1N2YwZDE0YTc0NzAyOTRmNzVkMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.TUVPVN_10yHUOlqwdY7mGjhR271srdxpmKcikB0zuHM)
Add Service Modal (with error message)
![Screenshot 2025-02-05 at 20 02 13](https://private-user-images.githubusercontent.com/7639854/410160863-dda447bd-c8a2-4bb9-b4a7-d70b3da75c6f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODAzNTEsIm5iZiI6MTczOTI4MDA1MSwicGF0aCI6Ii83NjM5ODU0LzQxMDE2MDg2My1kZGE0NDdiZC1jOGEyLTRiYjktYjRhNy1kNzBiM2RhNzVjNmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMyMDUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OGY3YTAzNTJjNTVmZDQ4M2JmMjAxZWE5MDFkYTQ2MDRjYjE3NDI1MjRlZjM1ODhjOWU1ZmJkMzkxZTQ4ZTFjNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.PYLXv3zQdfkU3ldBJAZ48r0vy4OjVLs7M6qiK_zpdrc)