Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use dl.fedoraproject.org and associated URLs #90

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nullr0ute
Copy link
Member

If we use dl.fedoraproject.org it will use CDN where possible so
should help speed up if it's hit the CDN before. Also use the
more standard locations for vmlinuz/initrd so it works on all
the architectures.

Signed-off-by: Peter Robinson [email protected]

Copy link
Member

@puiterwijk puiterwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the ostree change for now, and we can merge it.
The fact that initrd/vmlinuz aren't used we can just ignore, since I should've cleaned that up from the code.

"compose_name": "IoT",
"clear_parts": True,
"install_type": "ostree",
"ostree": {
"osname": "fedora-iot-stable",
"remote": "fedora-iot",
"repo": "https://kojipkgs.fedoraproject.org/compose/iot/repo/",
"repo": "https://dl.fedoraproject.org/pub/alt/iot/",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be the URL to the ostsree repository, and because of anaconda limitations cannot be the mirrorlist we have been shipping.
So because of that limitation, I don't think there's really any other URL we can put here for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that to be https://ostree.fedoraproject.org/iot/ I updated it

compose_url = f"{info['compose_root']}/compose/{info['compose_name']}/:arch:/os"
instance.kernel_url = f"{compose_url}/isolinux/vmlinuz"
compose_url = f"{info['compose_root']}/{info['compose_name']}/:arch:/os"
instance.kernel_url = f"{compose_url}/images/pxeboot/vmlinuz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vmlinuz and initrd here aren't actually used, https://github.com/fedora-iot/zezere/blob/master/zezere/__init__.py#L17 means we download the current f32 initrd/vmlinuz for supported arches and those get used for all trees.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so we effectively cache them local to zezere?

@@ -54,8 +54,8 @@ def generate_auto_runreq(sender, instance, **kwargs):
instance.type = info["type"]

if "compose_root" in info:
compose_url = f"{info['compose_root']}/compose/{info['compose_name']}/:arch:/os"
instance.kernel_url = f"{compose_url}/isolinux/vmlinuz"
compose_url = f"{info['compose_root']}/{info['compose_name']}/:arch:/os"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is still useful though, since it decides where the stage2 (anaconda) gets pulled from.

If we use dl.fedoraproject.org it will use CDN where possible so
should help speed up if it's hit the CDN before. Also use the
more standard locations for vmlinuz/initrd so it works on all
the architectures.

Signed-off-by: Peter Robinson <[email protected]>
Update the UEFI URLs to pull from the public information. This is better than
grabbing from the koji interface as it's where the downloads on iot.fp.o
originate from as well.

Signed-off-by: Peter Robinson <[email protected]>
@nullr0ute nullr0ute added this to the 0.6 milestone May 7, 2020
Base automatically changed from master to main January 15, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants