-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use dl.fedoraproject.org and associated URLs #90
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the ostree change for now, and we can merge it.
The fact that initrd/vmlinuz aren't used we can just ignore, since I should've cleaned that up from the code.
zezere/runreqs.py
Outdated
"compose_name": "IoT", | ||
"clear_parts": True, | ||
"install_type": "ostree", | ||
"ostree": { | ||
"osname": "fedora-iot-stable", | ||
"remote": "fedora-iot", | ||
"repo": "https://kojipkgs.fedoraproject.org/compose/iot/repo/", | ||
"repo": "https://dl.fedoraproject.org/pub/alt/iot/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be the URL to the ostsree repository, and because of anaconda limitations cannot be the mirrorlist we have been shipping.
So because of that limitation, I don't think there's really any other URL we can put here for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant that to be https://ostree.fedoraproject.org/iot/ I updated it
compose_url = f"{info['compose_root']}/compose/{info['compose_name']}/:arch:/os" | ||
instance.kernel_url = f"{compose_url}/isolinux/vmlinuz" | ||
compose_url = f"{info['compose_root']}/{info['compose_name']}/:arch:/os" | ||
instance.kernel_url = f"{compose_url}/images/pxeboot/vmlinuz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vmlinuz and initrd here aren't actually used, https://github.com/fedora-iot/zezere/blob/master/zezere/__init__.py#L17 means we download the current f32 initrd/vmlinuz for supported arches and those get used for all trees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so we effectively cache them local to zezere?
@@ -54,8 +54,8 @@ def generate_auto_runreq(sender, instance, **kwargs): | |||
instance.type = info["type"] | |||
|
|||
if "compose_root" in info: | |||
compose_url = f"{info['compose_root']}/compose/{info['compose_name']}/:arch:/os" | |||
instance.kernel_url = f"{compose_url}/isolinux/vmlinuz" | |||
compose_url = f"{info['compose_root']}/{info['compose_name']}/:arch:/os" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is still useful though, since it decides where the stage2 (anaconda) gets pulled from.
If we use dl.fedoraproject.org it will use CDN where possible so should help speed up if it's hit the CDN before. Also use the more standard locations for vmlinuz/initrd so it works on all the architectures. Signed-off-by: Peter Robinson <[email protected]>
Update the UEFI URLs to pull from the public information. This is better than grabbing from the koji interface as it's where the downloads on iot.fp.o originate from as well. Signed-off-by: Peter Robinson <[email protected]>
If we use dl.fedoraproject.org it will use CDN where possible so
should help speed up if it's hit the CDN before. Also use the
more standard locations for vmlinuz/initrd so it works on all
the architectures.
Signed-off-by: Peter Robinson [email protected]