Skip to content

Commit

Permalink
default, extras: remove auto-optimalization
Browse files Browse the repository at this point in the history
- Right now pngquant will produce 8bit fixed color palette PNGs,
  which is absolutely not what you want in 95% of cases. No amount
  of dithering will result in no color banding when the abstract
  wallpaper is relying on 24 or even 48bit.
- Avoiding color banding with dithering is a deliberate controlled
  process done during the creation

Fixes #57
  • Loading branch information
jimmac authored and AdamWill committed Sep 11, 2023
1 parent b4ad61d commit 8e432ec
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
10 changes: 4 additions & 6 deletions default/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ MATE_BG_DEFAULT=$(DESTDIR)/usr/share/backgrounds/mate
PLASMA_BG_DIR=$(DESTDIR)/usr/share/plasma/desktoptheme
XFCE_BG_DIR=$(DESTDIR)/usr/share/xfce4/backdrops
INKSCAPE=/usr/bin/inkscape
PNGQUANT=/usr/bin/pngquant
MKDIR=/bin/mkdir -p
INSTALL=/usr/bin/install -p -m644 -D
LN_S=/bin/ln -s
Expand All @@ -19,12 +18,11 @@ all:

install:
$(MKDIR) $(WP_DIR)/default
#~ Base background and optimization
for tod in 01-day 01-night; do \
$(PNGQUANT) -o $(WP_DIR)/default/$(WP_NAME)-$${tod}.png \
$(WP_NAME)-$${tod}.png ; \
done;
$(INSTALL) $(WP_NAME).xml $(WP_DIR)/default/$(WP_NAME).xml
#~ Base background and optimization
for tod in 01-day 01-night; do \
$(INSTALL) $(WP_NAME)-$${tod}.png $(WP_DIR)/default/$(WP_NAME)-$${tod}.png ; \
done;

#~ GNOME background
$(MKDIR) $(GNOME_BG_DIR)
Expand Down
2 changes: 1 addition & 1 deletion extras/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ install:
done;
#~ Compress to 8-bit png format
for theme in $(THEMES_PNG) ; do \
$(PNGQUANT) -o $(F39_DIR)/extras/$${theme}.png $${theme}.png ;\
$(INSTALL) $${theme}.png $(F39_DIR)/extras/$${theme}.png ; \
$(MKDIR) $(KDE_BG_DIR)/F39_$${theme}/contents/images ;\
$(INSTALL) $${theme}.desktop $(KDE_BG_DIR)/F39_$${theme}/metadata.desktop ; \
for res in 1280x1024 \
Expand Down

0 comments on commit 8e432ec

Please sign in to comment.