Back to biome, now with an actually good configuration

.pre-commit-config.yaml

@@ -24,6 +24,12 @@ repos:
       - id: ruff
         args: [--unsafe-fixes]
       - id: ruff-format
+  - repo: https://github.com/biomejs/pre-commit
+    rev: "v0.4.0"
+    hooks:
+      - id: biome-check
+        additional_dependencies: ["@biomejs/[email protected]"]
+        args: [--unsafe]
   - repo: https://github.com/tox-dev/pyproject-fmt
     rev: 2.2.3
     hooks:
@@ -32,18 +38,3 @@ repos:
     rev: v0.19
     hooks:
       - id: validate-pyproject
-  - repo: local
-    hooks:
-      - id: prettier
-        name: prettier
-        entry: npx [email protected] --no-semi --write
-        language: system
-        types_or: [css, scss]
-        require_serial: true
-      - id: eslint
-        name: eslint
-        entry: yarn eslint
-        language: system
-        types_or: [javascript]
-        require_serial: true
-        verbose: true

biome.json

@@ -0,0 +1,57 @@
+{
+  "$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
+  "organizeImports": {
+    "enabled": false
+  },
+  "formatter": {
+    "enabled": true,
+    "indentStyle": "space",
+    "indentWidth": 2
+  },
+  "linter": {
+    "enabled": true,
+    "rules": {
+      "recommended": true,
+      "a11y": {
+        "noSvgWithoutTitle": "off"
+      },
+      "correctness": {
+        "noUndeclaredVariables": "error",
+        "noUnusedImports": "error",
+        "noUnusedVariables": "error",
+        "useArrayLiterals": "error",
+        "useHookAtTopLevel": "error"
+      },
+      "security": {
+        "noDangerouslySetInnerHtml": "warn"
+      },
+      "style": {
+        "noParameterAssign": "off",
+        "useForOf": "warn"
+      },
+      "suspicious": {
+        "noArrayIndexKey": "warn",
+        "noAssignInExpressions": "off"
+      }
+    }
+  },
+  "javascript": {
+    "formatter": {
+      "semicolons": "asNeeded"
+    },
+    "globals": ["django", "CKEDITOR"]
+  },
+  "css": {
+    "formatter": {
+      "enabled": true
+    },
+    "linter": {
+      "enabled": true
+    }
+  },
+  "json": {
+    "formatter": {
+      "enabled": false
+    }
+  }
+}

feincms3/inline_ckeditor.py

@@ -1,6 +1,5 @@
 import json
 
-import django
 from django import forms
 from django.conf import settings
 from django.core.checks import Warning
@@ -160,8 +159,6 @@ def __init__(self, *args, **kwargs):
 
         attrs = kwargs.setdefault("attrs", {})
         attrs["data-inline-cke"] = id(self.config)
-        if django.VERSION < (4, 2):
-            attrs["data-inline-cke-dj41"] = True
         super().__init__(*args, **kwargs)
 
     @property

feincms3/static/feincms3/inline-ckeditor.js

@@ -15,22 +15,23 @@
   onReady(() => {
     const configs = {}
     const scripts = document.querySelectorAll("[data-inline-cke-config]")
-    scripts.forEach(function parseConfig(script) {
+    for (const script of scripts) {
       configs[script.dataset.inlineCkeId] = JSON.parse(
         script.dataset.inlineCkeConfig,
       )
-    })
+    }
 
     function initializeInlineCKE() {
-      document.querySelectorAll("textarea[data-inline-cke]").forEach((el) => {
+      const textareas = document.querySelectorAll("textarea[data-inline-cke]")
+      for (const el of textareas) {
         if (
           el.dataset.inlineCke !== "active" &&
           !el.id.includes("__prefix__")
         ) {
           CKEDITOR.replace(el, configs[el.dataset.inlineCke])
           el.dataset.inlineCke = "active"
         }
-      })
+      }
     }
 
     function addFormsetAddedHandler() {