F/277 display flow tree #872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented `getJobTree` method in `BaseAdapter` for retrieving job tree structure. - Added empty implementation in `BullAdapter` to return an empty array. - Developed full functionality in `BullMQAdapter` to fetch and map job tree nodes from the queue. This enhances the API for better job management and visualization.
…dren Modified the JobTreeNode interface in app.ts to replace the optional children property with jobTree, enhancing the structure for representing job hierarchies in the API.
Updated the getJobState function to extract jobId from the request parameters and retrieve the job tree structure using the new getJobTree method. The response now includes the job tree, improving job management and visualization capabilities in the API.
Updated the BullMQAdapter's mapTree function to handle asynchronous job state retrieval and ensure proper mapping of job trees. The JobTreeNode interface has been modified to include queueName and status properties, improving the representation of job hierarchies in the API.
- Added a new JobTree component to visualize job hierarchies. - Introduced JobTree.module.css for styling the JobTree component. - Updated useJob hook to include jobTree state management. - Modified JobPage to render JobTree with job data. - Enhanced localization files to include "Children" translations for job tree representation. - Refactored JobCard and related components to improve layout and structure. These changes improve the user interface for job management and provide better visualization of job relationships.
Updated JobPage to only display the JobTree component when there are child jobs available. This change improves the user interface by preventing unnecessary rendering of the JobTree when it is empty, enhancing overall performance and user experience.
|
I didn't forgot about this PR, I'm a bit busy, I'll review it ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #277 and #681
This PR displays a tree-like graph for any job that was generated by a
FlowProducerand it allows users to navigate the tree, up or down the tree.Screen.Recording.2025-01-06.at.5.11.37.PM.mov
The changes made cover
apianduipackages.The CSS and styling in
JobTree.module.cssare not that great. I admit that my skills aren't great. So, please make the necessary changes to remove any repetition or redundancies.I'll close #870 because all changes are already included in this PR.
Thanks for the feedback on my previous PR.