Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when getting aliases by name #17

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

freya022
Copy link
Contributor

No description provided.

Improves performance for getByAlias and sibling methods
# Conflicts:
#	lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java
lib/src/jmh/java/benchmark/EmojiManagerBenchmark.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
lib/src/main/java/net/fellbaum/jemoji/EmojiManager.java Outdated Show resolved Hide resolved
Copy link
Owner

@felldo felldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@felldo felldo merged commit 8f336b6 into felldo:master Nov 13, 2023
1 check passed
@freya022 freya022 deleted the refactor/get-by-alias branch November 13, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants