Merge 'Error if Decompress or Compress fails' (OoTRandomizer#2229)

Main.py

@@ -241,7 +241,7 @@ def compress_rom(input_file: str, output_file: str, delete_input: bool = False)
         logger.info("OS not supported for ROM compression.")
         raise Exception("This operating system does not support ROM compression. You may only output patch files or uncompressed ROMs.")
 
-    run_process(logger, [compressor_path, input_file, output_file])
+    run_process(logger, [compressor_path, input_file, output_file], check=True)
     if delete_input:
         os.remove(input_file)
 

README.md

@@ -129,6 +129,7 @@ issue. You should always Hard Reset to avoid this issue entirely.
 * Fix importing settings from older versions on web.
 * Fix a Mac-specific issue when loading track .meta files.
 * Fix an error in the easy bite fishing hack.
+* The randomizer no longer ignores errors when decompressing the base rom or compressing the randomized rom.
 
 #### New Speedups
 * The first text box from each carpenter in the Thieves' Hideout is skipped.

Rom.py

@@ -126,7 +126,7 @@ def decompress_rom(self, input_file: str, output_file: str, verify_crc: bool = T
         else:
             raise RuntimeError('Unsupported operating system for decompression. Please supply an already decompressed ROM.')
 
-        subprocess.call(subcall, **subprocess_args())
+        subprocess.check_call(subcall, **subprocess_args())
         self.read_rom(output_file, verify_crc=verify_crc)
 
     def write_byte(self, address: int, value: int) -> None:

Utils.py

@@ -199,23 +199,20 @@ def subprocess_args(include_stdout: bool = True) -> dict[str, Any]:
     return ret
 
 
-def run_process(logger: logging.Logger, args: Sequence[str], stdin: Optional[AnyStr] = None) -> None:
+def run_process(logger: logging.Logger, args: Sequence[str], stdin: Optional[AnyStr] = None, *, check: bool = False) -> None:
     process = subprocess.Popen(args, bufsize=1, stdout=subprocess.PIPE, stdin=subprocess.PIPE)
-    filecount = None
     if stdin is not None:
         process.communicate(input=stdin)
     else:
         while True:
             line = process.stdout.readline()
             if line != b'':
-                find_index = line.find(b'files remaining')
-                if find_index > -1:
-                    files = int(line[:find_index].strip())
-                    if filecount is None:
-                        filecount = files
                 logger.info(line.decode('utf-8').strip('\n'))
             else:
                 break
+        process.communicate()
+    if check and process.returncode != 0:
+        raise subprocess.CalledProcessError(process.returncode, args)
 
 
 # https://stackoverflow.com/a/23146126

version.py

@@ -1,4 +1,4 @@
-__version__ = '8.2.37'
+__version__ = '8.2.38'
 
 # This is a supplemental version number for branches based off of main dev.
 supplementary_version = 0