Merge pull request #1754 from fetchai/feature/conn_excep

change default connection exception policy

aea/aea.py

@@ -81,7 +81,7 @@ def __init__(
             DecisionMakerHandler
         ] = DefaultDecisionMakerHandler,
         skill_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate,
-        connection_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.just_log,
+        connection_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate,
         loop_mode: Optional[str] = None,
         runtime_mode: Optional[str] = None,
         default_connection: Optional[PublicId] = None,

aea/aea_builder.py

@@ -287,7 +287,7 @@ class AEABuilder:
         DecisionMakerHandler
     ] = DefaultDecisionMakerHandler
     DEFAULT_SKILL_EXCEPTION_POLICY = ExceptionPolicyEnum.propagate
-    DEFAULT_CONNECTION_EXCEPTION_POLICY = ExceptionPolicyEnum.just_log
+    DEFAULT_CONNECTION_EXCEPTION_POLICY = ExceptionPolicyEnum.propagate
     DEFAULT_LOOP_MODE = "async"
     DEFAULT_RUNTIME_MODE = "threaded"
     DEFAULT_SEARCH_SERVICE_ADDRESS = "fetchai/soef:*"

aea/multiplexer.py

@@ -81,7 +81,7 @@ def __init__(
         connections: Optional[Sequence[Connection]] = None,
         default_connection_index: int = 0,
         loop: Optional[AbstractEventLoop] = None,
-        exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.just_log,
+        exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate,
     ):
         """
         Initialize the connection multiplexer.

aea/runtime.py

@@ -114,7 +114,7 @@ def multiplexer(self) -> Multiplexer:
     def _get_multiplexer_instance(self) -> Multiplexer:
         """Create multiplexer instance."""
         exception_policy = getattr(
-            self._agent, "_connection_exception_policy", ExceptionPolicyEnum.just_log
+            self._agent, "_connection_exception_policy", ExceptionPolicyEnum.propagate
         )
         return Multiplexer(
             self._agent.connections, loop=self.loop, exception_policy=exception_policy

docs/api/aea.md

@@ -18,7 +18,7 @@ This class implements an autonomous economic agent.
 ```python
  | __init__(identity: Identity, wallet: Wallet, resources: Resources, loop: Optional[AbstractEventLoop] = None, period: float = 0.05, execution_timeout: float = 0, max_reactions: int = 20, decision_maker_handler_class: Type[
  |             DecisionMakerHandler
- |         ] = DefaultDecisionMakerHandler, skill_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate, connection_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.just_log, loop_mode: Optional[str] = None, runtime_mode: Optional[str] = None, default_connection: Optional[PublicId] = None, default_routing: Optional[Dict[PublicId, PublicId]] = None, connection_ids: Optional[Collection[PublicId]] = None, search_service_address: str = "fetchai/soef:*", **kwargs, ,) -> None
+ |         ] = DefaultDecisionMakerHandler, skill_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate, connection_exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate, loop_mode: Optional[str] = None, runtime_mode: Optional[str] = None, default_connection: Optional[PublicId] = None, default_routing: Optional[Dict[PublicId, PublicId]] = None, connection_ids: Optional[Collection[PublicId]] = None, search_service_address: str = "fetchai/soef:*", **kwargs, ,) -> None
 ```
 
 Instantiate the agent.

docs/api/multiplexer.md

@@ -74,7 +74,7 @@ This class can handle multiple connections at once.
 #### `__`init`__`
 
 ```python
- | __init__(connections: Optional[Sequence[Connection]] = None, default_connection_index: int = 0, loop: Optional[AbstractEventLoop] = None, exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.just_log)
+ | __init__(connections: Optional[Sequence[Connection]] = None, default_connection_index: int = 0, loop: Optional[AbstractEventLoop] = None, exception_policy: ExceptionPolicyEnum = ExceptionPolicyEnum.propagate)
 ```
 
 Initialize the connection multiplexer.

docs/config.md

@@ -45,6 +45,7 @@ execution_timeout: 0                            # The execution time limit on ea
 timeout: 0.05                                   # The sleep time on each AEA loop spin (only relevant for the `sync` mode)
 max_reactions: 20                               # The maximum number of envelopes processed per call to `react` (only relevant for the `sync` mode)
 skill_exception_policy: propagate               # The exception policy applied to skills (must be one of "propagate", "just_log", or "stop_and_exit")
+connection_exception_policy: propagate          # The exception policy applied to connections (must be one of "propagate", "just_log", or "stop_and_exit")
 default_routing: {}                             # The default routing scheme applied to envelopes sent by the AEA, it maps from protocol public ids to connection public ids (both keys and values must satisfy PUBLIC_ID_REGEX)
 loop_mode: async                                # The agent loop mode (must be one of "sync" or "async")
 runtime_mode: threaded                          # The runtime mode (must be one of "threaded" or "async") and determines how agent loop and multiplexer are run

tests/test_configurations/test_aea_config.py

@@ -261,7 +261,7 @@ class TestConnectionExceptionPolicyConfigVariable(BaseConfigTestVariable):
     INCORRECT_VALUES = [None, "sTrING?", -1]
     REQUIRED = False
     AEA_ATTR_NAME = "_connection_exception_policy"
-    AEA_DEFAULT_VALUE = ExceptionPolicyEnum.just_log
+    AEA_DEFAULT_VALUE = ExceptionPolicyEnum.propagate
 
 
 class TestRuntimeModeConfigVariable(BaseConfigTestVariable):

tests/test_docs/test_bash_yaml/md_files/bash-config.md

@@ -36,6 +36,7 @@ execution_timeout: 0                            # The execution time limit on ea
 timeout: 0.05                                   # The sleep time on each AEA loop spin (only relevant for the `sync` mode)
 max_reactions: 20                               # The maximum number of envelopes processed per call to `react` (only relevant for the `sync` mode)
 skill_exception_policy: propagate               # The exception policy applied to skills (must be one of "propagate", "just_log", or "stop_and_exit")
+connection_exception_policy: propagate          # The exception policy applied to connections (must be one of "propagate", "just_log", or "stop_and_exit")
 default_routing: {}                             # The default routing scheme applied to envelopes sent by the AEA, it maps from protocol public ids to connection public ids (both keys and values must satisfy PUBLIC_ID_REGEX)
 loop_mode: async                                # The agent loop mode (must be one of "sync" or "async")
 runtime_mode: threaded                          # The runtime mode (must be one of "threaded" or "async") and determines how agent loop and multiplexer are run

tests/test_multiplexer.py

@@ -612,19 +612,19 @@ def teardown(self):
         """Tear down test case."""
         self.multiplexer.disconnect()
 
-    def test_default_policy(self):
+    def test_log_policy(self):
         """Test just log exception."""
-        assert self.multiplexer._exception_policy == ExceptionPolicyEnum.just_log
-
         with patch.object(self.connection, "send", side_effect=self.exception):
+            self.multiplexer._exception_policy = ExceptionPolicyEnum.just_log
             self.multiplexer.put(self.envelope)
             time.sleep(1)
             assert not self.multiplexer._send_loop_task.done()
 
     def test_propagate_policy(self):
         """Test propagate exception."""
+        assert self.multiplexer._exception_policy == ExceptionPolicyEnum.propagate
+
         with patch.object(self.connection, "send", side_effect=self.exception):
-            self.multiplexer._exception_policy = ExceptionPolicyEnum.propagate
             self.multiplexer.put(self.envelope)
             time.sleep(1)
             wait_for_condition(