Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subtitles when no size received #447

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix subtitles when no size received #447

wants to merge 2 commits into from

Conversation

lukasf
Copy link
Member

@lukasf lukasf commented Dec 18, 2024

This fixes subtitles in the video reported by @ramtinak. If we do not get any size info for bitmap subs, we optimistically assume the size is same as the video size. Can't do any better than that.

@brabebhin
Copy link
Collaborator

Both VLC and PotPlayer seem to override the color.
Perhaps we should override the blacks with something else? I am not sure how to do it safely though, we'd have to keep black outlines but not black text. Difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants