Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed book style and started adding shell per outline #6

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jul 23, 2024

This PR begins by filling out the shell of this repo for Part 1 of the Data Visualization Course (Data Visualizations Considerations) by

  1. making style changes per the guide on ottrproject.org

  2. creating .Rmd chapters with headings based on the developed outline

  3. making some quick edits to the README and ._bookdown.yml files

Next steps will include filling out learning objectives and the names/motivation/goal sections of the index.Rmd and 01-intro.Rmd files.

Looking for feedback on layout and content of the shell -- e.g., is there anything that doesn't seem to be there that should be? Do we like the addition of EDA in the what is data visualization chapter (contrasting EDA vs more polished visualizations)?

@kweav kweav requested a review from carriewright11 July 23, 2024 22:40
@kweav
Copy link
Contributor Author

kweav commented Jul 23, 2024

@laderast I tried to add you as a reviewer to this too, but I seem to be missing how to do that.

Copy link

github-actions bot commented Jul 23, 2024

⚠️ broken url errors ⚠️
There are broken url errors that need to be addressed.
Click here ➡️ for broken url errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-11-06-23:17:35 with changes from 4d1b927

Copy link

github-actions bot commented Jul 23, 2024

No spelling errors! 🎉
Comment updated at 2024-11-06-23:17:36 with changes from 4d1b927

Copy link

github-actions bot commented Jul 23, 2024

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-11-06 with changes from the latest commit 4d1b927

@carriewright11 carriewright11 requested a review from laderast July 24, 2024 02:38
@carriewright11
Copy link

Looks great! The only thing I might change is shifting the "What are the parts of a data visualization?" Chapter to more of an emphasis on how to know what type of plot to use.

Also if the chapter titles are shorter it makes it easier for learners to navigate the table of contents (as they don't get cut off) , so you might want to consider changing them to be shorter.

@carriewright11
Copy link

Maybe work on learning objectives next

@carriewright11
Copy link

Might also be good to talk about distortions that can happen

Copy link
Collaborator

@laderast laderast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Kate. I mostly added a few links to other material if it's helpful.


## What is Data Visualization?

### Exploratory Data Analysis (EDA)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like the exploratory vs explanatory dichotomy for explaining the aims of visualization: https://laderast.github.io/data_storytelling_bdc/#5

- {LO1}
- {LO2}

## Visual Design Principles
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be helpful to talk about preattentive attributes and how they're used in viz design: https://laderast.github.io/data_storytelling_bdc/#22


## Data types

## Graph types
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @carriewright11 's suggestion, I like showing a decision tree like this to help people decide on visualizations: https://www.data-to-viz.com/

Probably need to also expand to include cancer informatics-specific visualizations, including genomics/volcano plots, etc

@kweav
Copy link
Contributor Author

kweav commented Aug 1, 2024

Thank you both, @carriewright11 and @laderast -- these are very helpful!

index.Rmd Outdated

## Available course formats
This course is part of a series of courses for the [Informatics Technology for Cancer Research (ITCR)](https://itcr.cancer.gov/) called the Informatics Technology for Cancer Research Education Resource. This material was created by the ITCR Training Network (ITN) which is a collaborative effort of researchers around the United States to support cancer informatics and data science training through resources, technology, and events. This initiative is funded by the following grant: [National Cancer Institute (NCI)](https://www.cancer.gov/) UE5 CA254170. Our courses feature tools developed by ITCR Investigators and make it easier for principal investigators, scientists, and analysts to integrate cancer informatics into their workflows. Please see our website at [www.itcrtraining.org](www.itcrtraining.org) for more information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This course is part of a series of courses for the [Informatics Technology for Cancer Research (ITCR)](https://itcr.cancer.gov/) called the Informatics Technology for Cancer Research Education Resource. This material was created by the ITCR Training Network (ITN) which is a collaborative effort of researchers around the United States to support cancer informatics and data science training through resources, technology, and events. This initiative is funded by the following grant: [National Cancer Institute (NCI)](https://www.cancer.gov/) UE5 CA254170. Our courses feature tools developed by ITCR Investigators and make it easier for principal investigators, scientists, and analysts to integrate cancer informatics into their workflows. Please see our website at [www.itcrtraining.org](www.itcrtraining.org) for more information.
This course is part of a series of courses for the [Informatics Technology for Cancer Research (ITCR)](https://www.cancer.gov/about-nci/organization/cssi/research/itcr). This material was created by the ITCR Training Network (ITN) which is a collaborative effort of researchers around the United States to support cancer informatics and data science training through resources, technology, and events. This initiative is funded by the following grant: [National Cancer Institute (NCI)](https://www.cancer.gov/) UE5 CA254170. Our courses feature tools developed by ITCR Investigators and make it easier for principal investigators, scientists, and analysts to integrate cancer informatics into their workflows. Please see our website at [www.itcrtraining.org](www.itcrtraining.org) for more information.

index.Rmd Outdated
- This course can be taken for [free certification through Leanpub](LINK HERE).
- This course can be taken on [Coursera for certification here](LINK HERE) (but it is not available for free on Coursera).
- Our courses are open source, you can find the [source material for this course on GitHub](LINK HERE).
The second course in the series will focus on building data visualizations, pointing to resources across R and Python, while integrating the best practice considerations discussed in this course.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add major objectives to the other course here

@carriewright11
Copy link

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants