-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting GitHub Metrics #10
Conversation
Looks like the metrics for this are limited to a 2 week span https://github.com/orgs/community/discussions/15189 womp womp. So we scraping here I come. |
Webscraping will still happen. But it will not address this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get_github_metrics()
is buggy, as described in my inline comments. I can take a look at what's causing the error.
I created a sub-branch of cansavvy/github
called howardbaek/github-fix
. I'll be working on that branch, and request a PR that merges my changes into cansavvy/github
Now, I'm getting this error message from running
I'm getting the same error message when running |
message("Cached Google .httr-oauth file deleted") | ||
if (app_name == "all" | app_name == "github") { | ||
if (github_creds_exist) { | ||
options(github_api = NULL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to DRY up some of this auth section in a future PR
I think this PR has gotten unwieldy. So my general strategy at this point is to:
Sound good @howardbaek ? |
Minor fix for Google Analytics function docs
I believe a majority of the bugs are fixed (until we find more when I build unit testing). @howardbaek Can you just test using:
And see if this works for you? if so then I think it would be easiest to merge this and go from there |
That code chunk works on my end, but |
Yeah I'm okay with tibbles or data frames. We can further discuss this data's format for future PRs but lets get this in for now |
Summary
Collecting all the metrics we might want from GitHub. Basically this summarizes to
There's also some creds handling improvements here.
Caveat
The metrics bit only reports the last two weeks. This is just a thing GitHub does that isn't great. So we will be able to have more than just two weeks of metrics but only after we start collecting and storing.