Add ability to specify which github stats to return #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cansavvy
commented
Oct 3, 2024
|
@kweav I feel pretty good about this code but you take a look and see if there's anything else we should improve. Tests are passing so feel free to approve/merge as you'd like. |
kweav
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
@kweav and I pair programmed on this. It is meant to address #88
We had to carry over the changes to a number of the arguments but it should be a bit cleaner now. People can specify a vector with what stats they'd like collected.
What was your approach?
We tested this interactively using the examples (and added some examples to the docs too)
What GitHub issue does your pull request address?
#88
Tell potential reviewers what kind of feedback you are soliciting.
@kweav and I might look at this with fresh eyes later just to see if there's anything else that could use polishing.