Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid response on cancel #381

Open
stdevAlDen opened this issue Jan 15, 2020 · 0 comments · May be fixed by #382
Open

Invalid response on cancel #381

stdevAlDen opened this issue Jan 15, 2020 · 0 comments · May be fixed by #382
Assignees
@stdevAlDen
Labels
bug Something isn't working firmware MCU firmware
Milestone
v2

Comments

@stdevAlDen
Copy link
Contributor

Describe the bug
Asking for Cancel through the procol should return a "cancelled as requested" not a "pin mismatch" like in the current implementation of changePin

Environment information:

  • OS: GNU/Linux
  • Platform: Linux 5.2.0-3-amd64 Fix travis #1 SMP Debian 5.2.17-1 (2019-09-26) x86_64
  • Firmware Version: f03191f

Steps to Reproduce
Send a cancel while changing the PIN.

Actual behavior
pin mismatch as response

Expected behavior
action canceled

Additional context
fibercrypto/fibercryptowallet#255
@stdevAlDen stdevAlDen added bug Something isn't working firmware MCU firmware labels Jan 15, 2020
@stdevAlDen stdevAlDen self-assigned this Jan 15, 2020
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Jan 22, 2020
@stdevAlDen
Fix chnagePin message
88ff147 
Change pin should return canceled when a cancel command is recived not a pin mismatch
ref fibercrypto#381
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Jan 31, 2020
@stdevAlDen
bootloader - fix firmware upload, button request on confirmaion troug…
d3715f6 
…h wire ref fibercrypto#381
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Feb 12, 2020
@stdevAlDen
fix change pin tests and remove pin implementation ref fibercrypto#381
2e1901c
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Feb 12, 2020
@stdevAlDen
fix format ref fibercrypto#381
31745a2
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Feb 12, 2020
@stdevAlDen
Merge branch 'stdevAlDen_t379_unprotect_first_address' into stdevAlDe…
7eb9394 
…n_t381_invald_response_on_cancel ref fibercrypto#381
@denisacostaq denisacostaq linked a pull request Feb 28, 2020 that will close this issue
Open
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Feb 28, 2020
@stdevAlDen
fix var initialization syntax ref fibercrypto#381
6f12ead
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 4, 2020
@stdevAlDen
add test for pin canceled ref fibercrypto#381
fef704f
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 4, 2020
@stdevAlDen
Merge branch 'stdevAlDen_t381_invald_response_on_cancel' of github.co…
343427e 
…m:simelo/skywallet-mcu into stdevAlDen_t381_invald_response_on_cancel ref fibercrypto#381
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 5, 2020
@stdevAlDen
add more tests for pin canceled ref fibercrypto#381
e8ac92e
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 5, 2020
@stdevAlDen
add more tests for pin canceled ref fibercrypto#381
feb6825
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 5, 2020
@stdevAlDen
add more tests for pin canceled ref fibercrypto#381
c762bad
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 5, 2020
@stdevAlDen
add more tests for pin canceled ref fibercrypto#381
27e99a4
stdevAlDen added a commit to simelo/skywallet-mcu that referenced this issue Mar 5, 2020
@stdevAlDen
add more tests for pin canceled ref fibercrypto#381
5f32cc5
@olemis olemis added this to the v2 milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdevAlDen stdevAlDen

Labels
bug Something isn't working firmware MCU firmware
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

invalid response on cancel fixes #381 simelo/skywallet-mcu
2 participants
@olemis @stdevAlDen