-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
invalid response on cancel fixes #381 #382
Open
denisacostaq
wants to merge
10
commits into
fibercrypto:develop
Choose a base branch
from
simelo:stdevAlDen_t381_invald_response_on_cancel
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
invalid response on cancel fixes #381 #382
denisacostaq
wants to merge
10
commits into
fibercrypto:develop
from
simelo:stdevAlDen_t381_invald_response_on_cancel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change pin should return canceled when a cancel command is recived not a pin mismatch ref fibercrypto#381
…n_t381_invald_response_on_cancel ref fibercrypto#381
stdevAlDen
added
bootloader
MCU bootloader
bug
Something isn't working
firmware
MCU firmware
labels
Feb 28, 2020
olemis
requested changes
Mar 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firmware test suite needs to cover the case of PIN op cancellation
…m:simelo/skywallet-mcu into stdevAlDen_t381_invald_response_on_cancel ref fibercrypto#381
olemis
changed the title
invald response on cancel
invalid response on cancel fixes #381
Mar 5, 2020
stdevAlDen
force-pushed
the
stdevAlDen_t381_invald_response_on_cancel
branch
3 times, most recently
from
March 5, 2020 21:11
c762bad
to
27e99a4
Compare
stdevAlDen
force-pushed
the
stdevAlDen_t381_invald_response_on_cancel
branch
from
March 5, 2020 21:18
27e99a4
to
5f32cc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #381
Changes:
Does this change need to mentioned in CHANGELOG.md?
no
Requires testing
yes