Update filecoin-plus.md #2365
Open
Update filecoin-plus.md #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes from the dogfooding report
lanzafame
requested changes
Feb 26, 2025
| @@ -117,23 +116,26 @@ If making deals through the [API](https://github.com/filecoin-project/lotus/blob | |||
| ] | |||
| ``` | |||
|
|
|||
| ### How to Use DataCap, using the Command Line | |||
| If making deals from the command line, make sure to pass the flag `--verified-deal=true` as a parameter. | |||
|
|
|||
| ```shell | |||
| lotus client deal --verified-deal=true | |||
There was a problem hiding this comment.
the client subcommand no longer exists in the lotus cli, so this whole section should be removed.
Comment on lines
+92
to
95
| ### How to Use DataCap, using the API | ||
|
|
||
| If making deals through the [API](https://github.com/filecoin-project/lotus/blob/master/documentation/en/api-v0-methods.md#ClientStartDeal), make sure that the `VerifiedDeal` parameter is set to `true` when calling `ClientStartDeal`. | ||
|
|
There was a problem hiding this comment.
the Client api endpoints have all been removed from the lotus daemon, so this section should be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from the dogfooding report. https://www.notion.so/filecoin/Fil-Documentation-v2-Report-1617631f28258033b155d19800af173f