Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testsuite for parallel spmv using mutex #668

Merged
merged 10 commits into from
Dec 12, 2024

Conversation

Paramuths
Copy link
Contributor

  1. Fix help message for test/runtests.jl
    • clean up nonexistence options
    • add possible options including parallel
  2. Create testsuite for parallel spmv using mutex in test/test_parallel.jl

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/tensors/levels/separate_levels.jl 57.14% 6 Missing ⚠️
src/tensors/levels/mutex_levels.jl 63.63% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/tensors/levels/mutex_levels.jl 61.14% <63.63%> (+0.24%) ⬆️
src/tensors/levels/separate_levels.jl 76.81% <57.14%> (+8.24%) ⬆️

... and 1 file with indirect coverage changes

test/runtests.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@willow-ahrens willow-ahrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo irrelevant formatting changes, transpose the matrix when necessary, and complete the test suite. Thanks!

test/test_parallel.jl Show resolved Hide resolved
test/test_parallel.jl Show resolved Hide resolved
@willow-ahrens willow-ahrens merged commit eda9f55 into finch-tensor:main Dec 12, 2024
8 checks passed
@Paramuths Paramuths deleted the add-testsuite branch December 17, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants