Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensor Init Bug Fix #670

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Tensor Init Bug Fix #670

merged 3 commits into from
Dec 12, 2024

Conversation

kylebd99
Copy link
Collaborator

Galley's tensor initialization is improper, leading to memory leaks between invocations.

This patch fixes that by updating the init to reference an expression rather than a tensor.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/Galley/FinchCompat/executor.jl 50.00% 3 Missing ⚠️
src/Galley/PlanAST/plan.jl 0.00% 1 Missing ⚠️
src/Galley/utility-funcs.jl 93.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/Galley/ExecutionEngine/execution-engine.jl 92.68% <100.00%> (+0.05%) ⬆️
src/Galley/PhysicalOptimizer/physical-optimizer.jl 99.19% <100.00%> (ø)
src/Galley/PlanAST/plan.jl 64.30% <0.00%> (ø)
src/Galley/utility-funcs.jl 44.29% <93.33%> (+6.23%) ⬆️
src/Galley/FinchCompat/executor.jl 87.09% <50.00%> (-9.06%) ⬇️

... and 2 files with indirect coverage changes

@willow-ahrens
Copy link
Collaborator

This looks good to me, can you verify that it fixes mateusz's issue?

@kylebd99
Copy link
Collaborator Author

Can confirm. Ran it with main and it crashes, ran it with this and it doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants