Code

Image Comments Composition#20

Code

Merged

finebel merged 14 commits intomainfinebel/EssentialFeed:mainfrom feature/image-comments/compositionfinebel/EssentialFeed:feature/image-comments/compositionCopy head branch name to clipboardMay 12, 2024

+602-79

Commits

Commits on May 11, 2024

• Duplicate FeedUIComposer as CommentsUIComposer

  finebel

  committed
  d9661ae

  Copy full SHA for d9661ae

• Set comments title

  finebel

  committed
  c07818c

  Copy full SHA for c07818c

• Load actions request comments

  finebel

  committed
  60c990a

  Copy full SHA for 60c990a

• Loading indicator is visible while loading comments

  finebel

  committed
  c0f87f1

  Copy full SHA for c0f87f1

• Render image comments

  finebel

  committed
  555277e

  Copy full SHA for 555277e

• Dispatches from background to main queue

  finebel

  committed
  2af08a7

  Copy full SHA for 2af08a7

• Move localization helpers to shared scope

  finebel

  committed
  a0b1ac2

  Copy full SHA for a0b1ac2

• Remove feed references from comments integration tests

  finebel

  committed
  9cc3bc2

  Copy full SHA for 9cc3bc2

• Proves request is canceled on comments view (ListViewController) deinit

  finebel

  committed
  ce8fb57

  Copy full SHA for ce8fb57

Commits on May 12, 2024

• Notifies selection handler on image selection

  finebel

  committed
  4c98ea9

  Copy full SHA for 4c98ea9

• Show comments on image selection

  finebel

  committed
  cdd6b42

  Copy full SHA for cdd6b42

• Extract endpoint URL creation into the API modules

  finebel

  committed
  73e7902

  Copy full SHA for 73e7902

• Extract test helpers to remove duplication

  finebel

  committed
  20095a4

  Copy full SHA for 20095a4

• Pass missing selection argument to FeedImageCellController in context of snapshot tests

  finebel

  committed
  fd239dc

  Copy full SHA for fd239dc