Logging and Infrastructure Optimizations #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we avoid crashing, since the `CoreDataFeedStore` is not a critical component which is required to be able to use the application
Now we leverage the managedObjectContext.userInfo dictionary to prevent loosing all the stored image data on a new cache insertion
This way we avoid wasting resources for unnecessary tasks
… to prevent warnings about unsupported ordered relationships in SwiftData
…t the same time Now, everytime we create / reuse a `FeedImageCell`, we reset the cell into a loading state with no retry button visible and an ongoing loading animation. Before, the cell would rely on the `LoadResourcePresenter` to call the appropriate `display` methods which would then configure the cell accordingly. But since we don't allow more than one loading operation for a given cell anymore, the loading triggered by `cellForRowAt` would have no effect, because the prefetch loading is still in progress. See https://github.com/essentialdevelopercom/essential-feed-case-study/pull/69/files for reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullStoreto recover from a failedCoreDataFeedStorecreation following the NullObject-PatternosframeworkNSManagedObjectContext.userInfodictionary to avoid loosing all stored image data when inserting a new feed into the cache