Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price component FpML mappings #2329

Merged
merged 41 commits into from
Aug 30, 2023
Merged

Price component FpML mappings #2329

merged 41 commits into from
Aug 30, 2023

Conversation

hugohills-regnosys
Copy link
Contributor

No description provided.

@hugohills-regnosys hugohills-regnosys requested a review from a team as a code owner August 22, 2023 15:02
@netlify
Copy link

netlify bot commented Aug 22, 2023 •
edited
Loading

✅ Deploy Preview for finos-cdm canceled.

Name Link
🔨 Latest commit c63de42
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/64ef1c31663c140008463dbc

@lolabeis lolabeis linked an issue Aug 23, 2023 that may be closed by this pull request
Harmonising the representation of additive price components #2183
Closed
lolabeis
lolabeis reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@lolabeis lolabeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have some comments re the following samples:

  • FX Barrierfx-ex12 and fx-ex13
  • (New) cap / floor w spread ird-ex22 and ird-ex23
  • Inverse floater ird-ex27

rosetta-source/src/main/rosetta/product-common-settlement-type.rosetta Outdated Show resolved Hide resolved
@hugohills-regnosys hugohills-regnosys merged commit ae969a0 into finos:master Aug 30, 2023
@hugohills-regnosys hugohills-regnosys deleted the price-component-mappings branch August 30, 2023 11:14
@hugohills-regnosys hugohills-regnosys mentioned this pull request Sep 1, 2023
Closed
@lolabeis lolabeis mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolabeis lolabeis lolabeis approved these changes

Assignees
No one assigned
Labels
Category: Modelling Complexity: Small/Bug/Mapping Something isn't working - Requires one TA approval Criticality: Medium/Low Target: Development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harmonising the representation of additive price components
3 participants
@hugohills-regnosys @lolabeis @eacunaISDA