Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JEAN BAPTISTE ZIADE MetadataAddressForAllPayoutPrice #3225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regnosys-prod-user
Copy link
Collaborator

No description provided.

Harmonization : ensure all Price components in Payout have [metadata address], was missing mainly for returnTerms->vol/var/correl and for optionPayout
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for finos-cdm ready!

Name Link
🔨 Latest commit e1e1654
🔍 Latest deploy log https://app.netlify.com/sites/finos-cdm/deploys/672cb212f1637d0008bc934d
😎 Deploy Preview https://deploy-preview-3225--finos-cdm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JBZ-Fragmos
Copy link
Contributor

JBZ-Fragmos commented Nov 7, 2024

Background :

Target :

  • merge any agreed components into Dev, before next major release that will incorporate such changes into Prod

@JBZ-Fragmos
Copy link
Contributor

as an info, had already raised the Issue about it last year...
see #2582

@JBZ-Fragmos
Copy link
Contributor

@Oblongs

thas it the PR mentioning today in CRWG call

kidnly review if this one might be merged in coming month with Dev 6

Thanks a lot

@LionelSG-REGnosys
Copy link
Contributor

kidnly review if this one might be merged in coming month with Dev 6

Can you please add a release note and reach out to a CDM Maintainer to review and approve. If this is done, we can release to CDM 6-dev on Friday,

@JBZ-Fragmos
Copy link
Contributor

Release Note

Background

Purpose is to ensure consistent usage accross the model of referencing accross the model for Price or PriceSchedule i.e. any attribute of such type in Payout model shall have [metadata address] for being possibly referenced in TradeLot->PriceQuantity.

Rationale :

  • Prior to change being released, issue is inconsistent situation where :
    • some attributes already have [metadata] annotation e.g. performancePayout->initialValuationPrice
    • others do not have it e.g. optionPayout->strike
  • One key benefit of having [metadata location] placed at TradeLot->PriceQuantity level as a consistent/generic characteristic is to leverage the reference mechanism in Event model, for designing Instruction which functional behavior is simple/smart i.e. updating Price (or Quantity) accross the Product model without having to create new instance of the whole Trade object.

What is being released ?

1 -
[metadata address] is added to the following attributes in Product model, when of type Price or PriceSchedule :

  • level (an attribute of Trigger)
  • varianceStrikePrice
  • volatilityStrikePrice
  • correlationStrikePrice
  • initialRate (an attribute of FloatingRateSpecification)

2 -
multiplierValue type (an attribute of QuantityMultiplier) is upgraded : from number to PriceQuantity.

Rationale : prior type number' is considered being both :

  • (a) poor in terms of business representation (because does permit to specify which value is at stake e.g. Price, Quantity, which unit, perUnit, etc. also there are use cases where the multiplierValue is an Observable value, hence an enrichment with new type PriceQuantity which also includes this attribute)
  • and (b) also lacking of [metadata] annotation, which cannot be added to type number (whereas such annotation is already included in the attributes of type PriceQuantity i.e. Price, Quantity, Observable)

@JBZ-Fragmos
Copy link
Contributor

@Oblongs @lolabeis @hugohills-regnosys
have included Release Note, please feel free to amend if missing anything, and then please release to Dev

@manel-martos manel-martos requested review from manel-martos and removed request for manel-martos January 15, 2025 16:36
@JBZ-Fragmos JBZ-Fragmos added Category: Modelling WG to Discuss To be discussed in the designated Working Group(s) DerivsWG and removed Rosetta labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Modelling Complexity: Minor Change Requires two TA approval Criticality: High DerivsWG Status: needs review Needs to be reviewed by Maintainer Target: Development WG to Discuss To be discussed in the designated Working Group(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants