Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priyanka amarnani related party mapping processor[5xx] #3259

Open
wants to merge 13 commits into
base: 5.x.x
Choose a base branch
from

Conversation

PayalKhanna
Copy link
Contributor

@PayalKhanna PayalKhanna commented Nov 15, 2024

update expectations for #3257

A new mapper for Related Party Role has been added; this solves the issue for missing roles or references.
issue: #3158

priyanka-amarnani and others added 5 commits November 14, 2024 17:38
….x.x' into priyanka-amarnaniRelatedPartyMappingProcessor

# Conflicts:
#	rosetta-source/src/main/resources/result-json-files/fpml-5-10/products/rates/bond-fwd-generic-ex01.json
#	rosetta-source/src/main/resources/result-json-files/fpml-5-10/products/rates/bond-fwd-generic-ex02.json
@PayalKhanna
Copy link
Contributor Author

@priyanka-amarnani can you please provide release notes for this attached as comment or .md file on this PR
Thanks

@PayalKhanna
Copy link
Contributor Author

@manel-martos can you review this please

@JayasriR
Copy link
Contributor

@manel-martos Can you please review this?

Copy link
Contributor

@hugohills-regnosys hugohills-regnosys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to map role from the FpML synonym not the CDM display name

manel-martos
manel-martos previously approved these changes Nov 25, 2024
Copy link
Contributor

@manel-martos manel-martos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes by @hugohills-regnosys and commited by @gopazoTH solve the ingestion issues observed on the previous contribution.

@PayalKhanna
Copy link
Contributor Author

@manel-martos can you please re review after the new expectations are generated

@PayalKhanna
Copy link
Contributor Author

PayalKhanna commented Nov 26, 2024

@priyanka-amarnani @gopazoTH
the Build is failing on python build for reason

[2024-11-25T16:34:07.701Z] ERROR cdm-python/test/semantics/test_validation.py - AttributeError: module 'cdm.product.template' has no attribute 'Product'

could you please have a look at these please

cc @manel-martos @hugohills-regnosys

@hugohills-regnosys
Copy link
Contributor

@priyanka-amarnani @gopazoTH the Build is failing on python build for reason

[2024-11-25T16:34:07.701Z] ERROR cdm-python/test/semantics/test_validation.py - AttributeError: module 'cdm.product.template' has no attribute 'Product'

could you please have a look at these please

cc @manel-martos @hugohills-regnosys

This was due to the python versions used in the build/test script incrementing, and the tests not running with the latest version. I have created a PR where the previous working versions are specified, see #3280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants