-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priyanka amarnani related party mapping processor[5xx] #3259
base: 5.x.x
Are you sure you want to change the base?
Priyanka amarnani related party mapping processor[5xx] #3259
Conversation
…files from testing
….x.x' into priyanka-amarnaniRelatedPartyMappingProcessor # Conflicts: # rosetta-source/src/main/resources/result-json-files/fpml-5-10/products/rates/bond-fwd-generic-ex01.json # rosetta-source/src/main/resources/result-json-files/fpml-5-10/products/rates/bond-fwd-generic-ex02.json
@priyanka-amarnani can you please provide release notes for this attached as comment or .md file on this PR |
@manel-martos can you review this please |
@manel-martos Can you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to map role from the FpML synonym not the CDM display name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes by @hugohills-regnosys and commited by @gopazoTH solve the ingestion issues observed on the previous contribution.
…atedPartyMappingProcessor # Conflicts: # RELEASE.md
@manel-martos can you please re review after the new expectations are generated |
@priyanka-amarnani @gopazoTH
could you please have a look at these please |
This was due to the python versions used in the build/test script incrementing, and the tests not running with the latest version. I have created a PR where the previous working versions are specified, see #3280 |
update expectations for #3257
A new mapper for Related Party Role has been added; this solves the issue for missing roles or references.
issue: #3158