Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs, workshop and deployment scripts to reflect finos/htc-grid #87

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix docs, workshop and deployment scripts to reflect finos/htc-grid #87

wants to merge 2 commits into from

Conversation

fgogolli
Copy link
Contributor

@fgogolli fgogolli commented Oct 15, 2024 •
edited
Loading

Description

  • Fix docs, workshop and deployment scripts to reflect finos/htc-grid
  • Fix delete_bucket.py script for Python3

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/controlplane) and kind (e.g. kind/improvement)

BONUS POINTS checklist:

  • Backfilled missing tests for code in same general area
  • Refactored something and made the world a better place

@fgogolli fgogolli added documentation Improvements or additions to documentation kind/improvement labels Oct 15, 2024
@fgogolli fgogolli assigned fgogolli and kirillsc and unassigned fgogolli Oct 15, 2024
@fgogolli fgogolli requested a review from kirillsc October 15, 2024 12:38
@fgogolli fgogolli assigned fgogolli and unassigned kirillsc Oct 15, 2024
kirillsc
kirillsc approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@kirillsc kirillsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcwtest adamcwtest adamcwtest approved these changes

@kirillsc kirillsc kirillsc approved these changes

Assignees

@fgogolli fgogolli

Labels
documentation Improvements or additions to documentation kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fgogolli @kirillsc @adamcwtest