Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean SourceSpecification part II #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean SourceSpecification part II #698

wants to merge 1 commit into from

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Aug 25, 2023 •
edited
Loading

  • Added a new end point to fetch a patch /project/{projectId}/patches/{patchReleaseVersionId}
  • Added DevelopmentStream abstract class to to know the source of a workspace
  • Added source field to Workspace model
  • Added Workspace field to Review model and deprecated workspace related info in Review model
  • Added a way to filter by target of Review

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Test Results

107 files  ±0  107 suites  ±0   4m 11s ⏱️ -10s
549 tests ±0  548 ✔️ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit e520505. ± Comparison against base commit e2e5817.

♻️ This comment has been updated with latest results.

@gayathrir11 gayathrir11 force-pushed the fix branch 3 times, most recently from 81228b1 to ec68e4f Compare August 28, 2023 12:29
@gayathrir11 gayathrir11 marked this pull request as ready for review August 28, 2023 13:02
@gayathrir11 gayathrir11 requested a review from a team as a code owner August 28, 2023 13:02
kevin-m-knight-gs
kevin-m-knight-gs requested changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@kevin-m-knight-gs kevin-m-knight-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to PatchApi and GitLabPatchApi should be separated out into their own PR.

legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/domain/api/patch/PatchApi.java Outdated Show resolved Hide resolved
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabPatchApi.java Outdated Show resolved Hide resolved
legend-sdlc-server/src/main/java/org/finos/legend/sdlc/server/gitlab/api/GitLabPatchApi.java Outdated Show resolved Hide resolved
@gayathrir11 gayathrir11 marked this pull request as draft August 29, 2023 06:22
@gayathrir11 gayathrir11 marked this pull request as ready for review September 1, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-m-knight-gs kevin-m-knight-gs kevin-m-knight-gs requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gayathrir11 @kevin-m-knight-gs