feat(auth): Added InvalidDynamicLinkDomain Error Code (#167)

* feat(auth): Added InvalidDynamicLinkDomain error code * Removed incorrect conditional in release workflow
firebase · Apr 8, 2020 · c6b8bba · c6b8bba
1 parent d9ca03c
commit c6b8bba
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 1 deletion.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -100,7 +100,6 @@ jobs:
         name: Release
 
     - name: Setup .NET Core
-      if: matrix.os == 'ubuntu-latest'
       uses: actions/setup-dotnet@v1
       with:
         dotnet-version: 2.2.108

diff --git a/FirebaseAdmin/FirebaseAdmin.Tests/Auth/EmailActionRequestTest.cs b/FirebaseAdmin/FirebaseAdmin.Tests/Auth/EmailActionRequestTest.cs
@@ -15,6 +15,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
 using FirebaseAdmin.Tests;
@@ -321,6 +322,35 @@ public async Task SignInWithEmailLinkUnexpectedResponse()
             Assert.Null(exception.InnerException);
         }
 
+        [Fact]
+        public async Task InvalidDynamicLinkDomain()
+        {
+            var json = $@"{{
+                ""error"": {{
+                    ""message"": ""INVALID_DYNAMIC_LINK_DOMAIN"",
+                }}
+            }}";
+            var handler = new MockMessageHandler()
+            {
+                StatusCode = HttpStatusCode.InternalServerError,
+                Response = json,
+            };
+            var auth = this.CreateFirebaseAuth(handler);
+
+            var exception = await Assert.ThrowsAsync<FirebaseAuthException>(
+                async () => await auth.GenerateSignInWithEmailLinkAsync(
+                    "[email protected]", ActionCodeSettings));
+
+            Assert.Equal(ErrorCode.InvalidArgument, exception.ErrorCode);
+            Assert.Equal(AuthErrorCode.InvalidDynamicLinkDomain, exception.AuthErrorCode);
+            Assert.Equal(
+                "Dynamic link domain specified in ActionCodeSettings is not authorized "
+                + "(INVALID_DYNAMIC_LINK_DOMAIN).",
+                exception.Message);
+            Assert.NotNull(exception.HttpResponse);
+            Assert.Null(exception.InnerException);
+        }
+
         private FirebaseAuth CreateFirebaseAuth(HttpMessageHandler handler)
         {
             var userManager = new FirebaseUserManager(new FirebaseUserManager.Args

diff --git a/FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorCode.cs b/FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorCode.cs
@@ -58,5 +58,10 @@ public enum AuthErrorCode
         /// No user record found for the given identifier.
         /// </summary>
         UserNotFound,
+
+        /// <summary>
+        /// Dynamic link domain specified in <see cref="ActionCodeSettings"/> is not authorized.
+        /// </summary>
+        InvalidDynamicLinkDomain,
     }
 }
diff --git a/FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorHandler.cs b/FirebaseAdmin/FirebaseAdmin/Auth/AuthErrorHandler.cs
@@ -56,6 +56,13 @@ internal sealed class AuthErrorHandler
                         AuthErrorCode.EmailAlreadyExists,
                         "The user with the provided email already exists")
                 },
+                {
+                    "INVALID_DYNAMIC_LINK_DOMAIN",
+                    new ErrorInfo(
+                        ErrorCode.InvalidArgument,
+                        AuthErrorCode.InvalidDynamicLinkDomain,
+                        "Dynamic link domain specified in ActionCodeSettings is not authorized")
+                },
                 {
                     "PHONE_NUMBER_EXISTS",
                     new ErrorInfo(