Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app_check, android): add option to use FIREBASE_APP_CHECK_DEBUG_TOKEN env variable as debug token on Android #12672

Closed
wants to merge 3 commits into from

Conversation

xVemu
Copy link

@xVemu xVemu commented Apr 19, 2024

Description

If you run your app, FIREBASE_APP_CHECK_DEBUG_TOKEN is present, and you're using debug provider, then it will use a token from env instead of generating one. It's useful in CI environments, where you don't have an option to copy token from logs and paste it to Firebase Console.

Related Issues

Partial fix for: #11719

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…TOKEN env variable as debug token on Android
@Lyokone
Copy link
Contributor

Lyokone commented Jul 26, 2024

Thanks for the PR. would you be able to bring this to iOS as well?

@Lyokone Lyokone added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Jul 26, 2024
@xVemu
Copy link
Author

xVemu commented Jul 26, 2024

After time, I think a better option is to let developers pass debugToken to FirebaseAppCheck.instance.activate function. They could read token from env by themselves or hard code it for debugging purpose. I've done some work on debug-token branch. Currently, it works well on Android, but not on iOS. I will try to work on that in near feature.

@xVemu xVemu closed this Jul 26, 2024
@xVemu
Copy link
Author

xVemu commented Jul 26, 2024

I've created new PR with mentioned change #13101

@firebase firebase locked and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked: customer-response Waiting for customer response, e.g. more information was requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants