XRP testnet #1
XRP testnet #1
Conversation
|
Please send me some testnet usdt |
|
Added ability to run on XRP Testnet |
| @@ -5,11 +5,17 @@ import * as fs from 'fs'; | |||
| import * as path from 'path' | |||
|
|
|||
|
|
|||
| require('dotenv').config(); | |||
There was a problem hiding this comment.
Why this was removed?
Without it the .env params won't be loaded into 'process.env' unless you defined these in the system environment beforehand.
| const SERVER_WSS: string = "wss://xrplcluster.com"; // change to "wss://testnet.xrpl-labs.com" if using XRP Testnet asset | ||
|
|
||
| //Enter the domain name as a string, for example: test.com | ||
| const DOMAIN: string = ""; |
There was a problem hiding this comment.
Why DOMAIN was added here?
Domain field is not set by default for any newly created accounts in Fireblocks hence it is redundant here.
| "SetFlag": 1 // --> Enable dest tag required | ||
| //"ClearFlag": 1 // --> Disable test tag required (remove SetFlag in this case) | ||
| } | ||
|
|
||
| await xrp_signer.signAndSubmitTransaction( | ||
| api, | ||
| fireblocksApiClient, | ||
| Number(VAULT_ACCOUNT_ID), |
There was a problem hiding this comment.
Reading from .env will result in vault account id as string hence it throws an error here. Casting is required.
If we want to remove the casting to Number, we should change the expected type in signAndSubmitTransaction and remove the toString() within the Fireblocks transaction payload.
No description provided.