Skip to content

Commit

Permalink
Removed dependency on wait_for_up as that is now part of the start ac…
Browse files Browse the repository at this point in the history
…tion
  • Loading branch information
andrewla committed Jan 9, 2025
1 parent d3b13c4 commit d8c5a44
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
21 changes: 0 additions & 21 deletions tests/framework/microvm.py
Original file line number Diff line number Diff line change
Expand Up @@ -1069,27 +1069,6 @@ def _dump_debug_information(self, exc: Exception):
f"Thread backtraces:\n{self.thread_backtraces}"
)

def wait_for_up(self, timeout=10):
"""Wait for guest running inside the microVM to come up and respond.
:param timeout: seconds to wait.
"""
try:
rc, stdout, stderr = self.ssh.run("true", timeout)
except subprocess.TimeoutExpired:
print(
f"Remote command did not respond within {timeout}s\n\n"
f"Firecracker logs:\n{self.log_data}\n"
f"Thread backtraces:\n{self.thread_backtraces}"
)
raise
assert rc == 0, (
f"Remote command exited with non-0 status code\n\n"
f"{rc=}\n{stdout=}\n{stderr=}\n\n"
f"Firecracker logs:\n{self.log_data}\n"
f"Thread backtraces:\n{self.thread_backtraces}"
)

def wait_for_ssh_up(self):
"""Wait for guest running inside the microVM to come up and respond."""
# Ensure that we have an initialized SSH connection to the guest that can
Expand Down
2 changes: 0 additions & 2 deletions tests/integration_tests/functional/test_snapshot_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,6 @@ def test_snapshot_rename_interface(uvm_nano, microvm_factory):
vm.add_net_iface(iface=iface1)
# Create an interface but don't attach it to the device
vm.start()
vm.wait_for_up()

snapshot = vm.snapshot_full()

Expand All @@ -569,4 +568,3 @@ def test_snapshot_rename_interface(uvm_nano, microvm_factory):
snapshot, rename_interfaces={base_iface.dev_name: "tap2"}
)
restored_vm.resume()
restored_vm.wait_for_up()

0 comments on commit d8c5a44

Please sign in to comment.