Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy-preview] Fix network bar durations #1719

Closed

Conversation

brisad
Copy link
Contributor

@brisad brisad commented Feb 1, 2019

No description provided.

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #1719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         178      178           
  Lines       12029    12029           
  Branches     2950     2953    +3     
=======================================
  Hits        10006    10006           
  Misses       1846     1846           
  Partials      177      177
Impacted Files Coverage Δ
src/profile-logic/marker-data.js 88.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506de00...f90dc4d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #1719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   83.18%   83.18%           
=======================================
  Files         178      178           
  Lines       12029    12029           
  Branches     2950     2953    +3     
=======================================
  Hits        10006    10006           
  Misses       1846     1846           
  Partials      177      177
Impacted Files Coverage Δ
src/profile-logic/marker-data.js 88.48% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 506de00...f90dc4d. Read the comment docs.

Copy link
Contributor

@mstange mstange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, sorry for the delay, I thought I had reviewed this long ago!

@julienw
Copy link
Contributor

julienw commented Feb 14, 2019

But don't we need to also change the startTime in data, because that's the value used in the network chart? The alternative is to use start and start + dur in the network chart (like we do elsewhere).

@julienw
Copy link
Contributor

julienw commented Feb 14, 2019

I'm stealing this issue because I need the fix for a tests :)

@mstange
Copy link
Contributor

mstange commented Feb 14, 2019

Yes, we need both fixes.

@julienw
Copy link
Contributor

julienw commented Feb 14, 2019

Closing in favor of #1752. Thanks @brisad, your investigation helped me by ensuring I was on the right path :)

@julienw julienw closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants