Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few caprica issues #17

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix a few caprica issues #17

wants to merge 14 commits into from

Conversation

XxX-Daniil-underscore-Zaikin-XxX
Copy link

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX commented Jun 19, 2024 •
edited
Loading

Just a few minor bugs I've found. I've tested this and believe it's ready to merge.

Here's what this PR does:

  • Brings build script out of deprecated versions
  • Doesn't crash when using caprica (since caprica_config_path wasn't defined)
  • Doesn't crash if no default caprica config is found
  • Doesn't throw an error if it doesn't build any scripts
  • Properly handles caprica warnings and errors

@XxX-Daniil-underscore-Zaikin-XxX XxX-Daniil-underscore-Zaikin-XxX marked this pull request as ready for review August 18, 2024 17:36
@XxX-Daniil-underscore-Zaikin-XxX
Copy link
Author

reminder to myself: see if caprica's extra symbols are enabled, and if they aren't then add an option to enable them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@XxX-Daniil-underscore-Zaikin-XxX