build(deps-dev): fix bump typescript-eslint from 8.4.0 to 8.6.0

Handle 'no-duplicate-type-constituents' linting rule update introduced in 8.5.0.

Signed-off-by: Chris. Webster <[email protected]>

lib/commit-lint.ts

@@ -19,7 +19,7 @@ export class LintCommit {
     private messages: string[] = [];
     private maxColumns = 76;
 
-    public constructor(patch: IPRCommit, options?: ILintOptions | undefined) {
+    public constructor(patch: IPRCommit, options?: ILintOptions) {
         this.blocked = false;
         this.lines = patch.message.split("\n");
         this.patch = patch;

lib/git.ts

@@ -19,7 +19,7 @@ function trimTrailingNewline(str: string): string {
     return str.replace(/\r?\n$/, "");
 }
 
-export function git(args: string[], options?: IGitOptions | undefined): Promise<string> {
+export function git(args: string[], options?: IGitOptions): Promise<string> {
     const workDir = options && options.workDir || ".";
     if (options && options.trace) {
         process.stderr.write(`Called 'git ${args.join(" ")}' in '${workDir}':\n${new Error().stack}\n`);

lib/github-glue.ts

@@ -192,7 +192,7 @@ export class GitHubGlue {
     public async addPRCommitComment(pullRequest: pullRequestKeyInfo,
                                     commit: string,
                                     gitWorkDir: string | undefined,
-                                    comment: string, line?: number | undefined):
+                                    comment: string, line?: number):
         Promise<{ id: number; url: string }> {
         const prKey = getPullRequestKey(pullRequest);
 
@@ -248,7 +248,7 @@ export class GitHubGlue {
      * @param {string} title the updated title
      * @returns the PR number
      */
-    public async updatePR(prKey: pullRequestKey, body?: string | undefined, title?: string): Promise<number> {
+    public async updatePR(prKey: pullRequestKey, body?: string, title?: string): Promise<number> {
         await this.ensureAuthenticated(prKey.owner);
 
         const result = await this.client.rest.pulls.update({

package.json

@@ -71,7 +71,7 @@
     "ts-jest-resolver": "^2.0.1",
     "ts-node": "^10.9.2",
     "typescript": "^5.6.2",
-    "typescript-eslint": "8.4.0"
+    "typescript-eslint": "8.6.0"
   },
   "dependencies": {
     "@octokit/auth-app": "^7.1.1",