Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: library bump to handle cash prices reporting 0 as unavailable #111

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

firstof9
Copy link
Owner

@firstof9 firstof9 commented Oct 30, 2024

fixes #110

@firstof9 firstof9 marked this pull request as ready for review October 30, 2024 15:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (7f1850b) to head (017f319).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   77.93%   77.93%           
=======================================
  Files           6        6           
  Lines         349      349           
=======================================
  Hits          272      272           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@firstof9 firstof9 merged commit 8c078cb into main Oct 30, 2024
5 checks passed
@firstof9 firstof9 deleted the fix-110 branch October 30, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 0 cash price reports 0 should be reporting null
2 participants