Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revocation checking & POST api/v0/revocations endpoint #201

Merged
merged 12 commits into from
Dec 19, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Dec 11, 2023

Closing #185

TODO

  • Check revocations in authority validation.
  • Create revocations when deleting accounts
  • Tests for the revocation endpoint

@matheus23 matheus23 self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #201 (74eb0bc) into main (652c373) will increase coverage by 1.89%.
Report is 1 commits behind head on main.
The diff coverage is 32.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   18.08%   19.97%   +1.89%     
==========================================
  Files          63       67       +4     
  Lines        2588     2718     +130     
  Branches     1599     1665      +66     
==========================================
+ Hits          468      543      +75     
+ Misses       1492     1465      -27     
- Partials      628      710      +82     
Files Coverage Δ
fission-core/src/ed_did_key.rs 55.17% <100.00%> (+3.44%) ⬆️
fission-core/src/lib.rs 100.00% <ø> (ø)
fission-server/src/middleware/logging.rs 21.89% <ø> (ø)
fission-server/src/router.rs 16.66% <0.00%> (-0.48%) ⬇️
fission-server/src/error.rs 35.71% <0.00%> (-1.33%) ⬇️
fission-server/src/routes/capability_indexing.rs 26.66% <25.00%> (+1.66%) ⬆️
fission-cli/src/lib.rs 0.00% <0.00%> (ø)
fission-core/src/common.rs 0.00% <0.00%> (ø)
fission-server/src/db/schema.rs 11.11% <20.00%> (+1.11%) ⬆️
fission-server/src/models/capability_indexing.rs 29.54% <50.00%> (+3.93%) ⬆️
... and 7 more

... and 3 files with indirect coverage changes

Also:
- refactor `get_capabilities` to do the UCAN validation & revocation checking
  (and doing the audience matching, instead of that happening during extraction)
- rename `EdDidKey::as_str` into `did_as_str`
- Make `get_capabilities` return `AppError` intsead of `anyhow::Error`
@matheus23 matheus23 marked this pull request as ready for review December 15, 2023 15:06
@matheus23 matheus23 merged commit e075eae into main Dec 19, 2023
8 checks passed
@matheus23 matheus23 deleted the matheus23/revocation branch December 19, 2023 10:38
@matheus23 matheus23 mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant