Merge pull request #19 from fivetran/bugfix/timestamp-casts

Bugfix/timestamp casts
fivetran · Jan 25, 2022 · eb6d313 · eb6d313
2 parents 11b1b6f + 3567ae9
commit eb6d313
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# dbt_github_source v0.4.1
+
+## Fixes
+- Added the `{{ dbt_utils.type_timestamp() }}` cast function to timestamp fields within the staging models. This is required for Redshift users that have the fields originally synced as `timestamptz`. Without the casting of fields the downstream date functions will fail. ([#19](https://github.com/fivetran/dbt_github_source/pull/19))
+
 # dbt_github_source v0.4.0
 🎉 dbt v1.0.0 Compatibility 🎉
 ## 🚨 Breaking Changes 🚨

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,7 +1,7 @@
 config-version: 2
 
 name: 'github_source'
-version: '0.4.0'
+version: '0.4.1'
 
 require-dbt-version: [">=1.0.0", "<2.0.0"]
 

diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'github_source_integration_tests'
-version: '0.3.0'
+version: '0.4.1'
 config-version: 2
 
 profile: 'integration_tests'

diff --git a/models/stg_github__issue.sql b/models/stg_github__issue.sql
@@ -26,16 +26,16 @@ with issue as (
     select 
       id as issue_id,
       body,
-      closed_at,
-      created_at,
+      cast(closed_at as {{ dbt_utils.type_timestamp() }}) as closed_at,
+      cast(created_at as {{ dbt_utils.type_timestamp() }}) as created_at,
       locked as is_locked,
       milestone_id,
       number as issue_number,
       pull_request as is_pull_request,
       repository_id,
       state,
       title,
-      updated_at,
+      cast(updated_at as {{ dbt_utils.type_timestamp() }}) as updated_at,
       user_id
 
     from macro

diff --git a/models/stg_github__issue_closed_history.sql b/models/stg_github__issue_closed_history.sql
@@ -25,7 +25,7 @@ with issue_closed_history as (
 
     select 
       issue_id,
-      updated_at,
+      cast(updated_at as {{ dbt_utils.type_timestamp() }}) as updated_at,
       closed as is_closed
 
     from macro

diff --git a/models/stg_github__issue_merged.sql b/models/stg_github__issue_merged.sql
@@ -25,7 +25,7 @@ with issue_merged as (
 
     select 
       issue_id,
-      merged_at
+      cast(merged_at as {{ dbt_utils.type_timestamp() }}) as merged_at
 
     from macro
 )

diff --git a/models/stg_github__pull_request_review.sql b/models/stg_github__pull_request_review.sql
@@ -26,7 +26,7 @@ with pull_request_review as (
     select 
       id as pull_request_review_id,
       pull_request_id,
-      submitted_at,
+      cast(submitted_at as {{ dbt_utils.type_timestamp() }}) as submitted_at,
       state,
       user_id
 

diff --git a/models/stg_github__requested_reviewer_history.sql b/models/stg_github__requested_reviewer_history.sql
@@ -25,7 +25,7 @@ with requested_reviewer_history as (
 
     select 
       pull_request_id,
-      created_at,
+      cast(created_at as {{ dbt_utils.type_timestamp() }}) as created_at,
       requested_id,
       removed