-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multifile yaml #570
feat: allow multifile yaml #570
Conversation
Hey, thanks I will take a look over the weekend. |
Hi, Option 1: Not only return the parsed data, but also some options/flags that need to be passed to the dump invocation Option 2 would make more sense IMHO. WDYT? |
You can try a class with some state but not that also the combinations of multifile and multiple changes should work. I know thats not that easy to achieve, thats one of the reason I do not implement this feature yet |
@fjogeleit does the new test |
Hey @holzgeist, I am on a conference this week but will check it out next week. can you check the codestyle checks? the missing pr stuff is probably not working correctly. Will check the tests manually. looks good in the first place, thanks |
Thanks! I ran prettier, tests and co. now. Hopefully it works I even added some documentation to the readme 😄 |
thanks for your work |
* feat: allow multifile yaml * test: don't require leading $ * chore: run prettier * fix: package * fix: output multifile if input was multifile * fix: run `npm run package` * chore: run prettier * chore: run npm package * doc: add example in README.md * fix: apply linter suggestion
* support quotingType config Signed-off-by: Frank Jogeleit <[email protected]> * update dist Signed-off-by: Frank Jogeleit <[email protected]> * dependency updates Signed-off-by: Frank Jogeleit <[email protected]> * feat: allow force pushes (fjogeleit#555) * feat: allow force option * chore: add input to actions.yaml * docs: add parameter * fix: use getBooleanInput * Handle PR exists as info instead failing Signed-off-by: Frank Jogeleit <[email protected]> * Upgrade to Node20 Signed-off-by: Frank Jogeleit <[email protected]> * Update Tooling (fjogeleit#560) * Update tooling Signed-off-by: Frank Jogeleit <[email protected]> * feat: allow multifile yaml (fjogeleit#570) * feat: allow multifile yaml * test: don't require leading $ * chore: run prettier * fix: package * fix: output multifile if input was multifile * fix: run `npm run package` * chore: run prettier * chore: run npm package * doc: add example in README.md * fix: apply linter suggestion * Update README.md (fjogeleit#580) * fix CI pipeline errors --------- Signed-off-by: Frank Jogeleit <[email protected]> Signed-off-by: Frank Jogeleit <[email protected]> Co-authored-by: Frank Jogeleit <[email protected]> Co-authored-by: Lawrence Aiello <[email protected]> Co-authored-by: Frank Jogeleit <[email protected]> Co-authored-by: holzgeist <[email protected]> Co-authored-by: Fabio Kapsahili <[email protected]>
related to #532
It allows to modify multifile yaml files, separated by
---
.If the input is a multifile, the value_path needs to start with an index, e.g.
[0].path.to.value
if the value should be changed in the first fileI'm not sure how to remove the
as unknown as ...
casts, my TypeScript is too rusty for this.ContentNode
hasContentNode[]
in its definition, so I feel like this is supposed to work, but it doesn't.