exchange if statements with match statement

fkie-cad · Jun 4, 2024 · 19c925b · 19c925b
1 parent 8734458
commit 19c925b
Showing 1 changed file with 46 additions and 53 deletions.
diff --git a/logprep/processor/field_manager/processor.py b/logprep/processor/field_manager/processor.py
@@ -119,59 +119,52 @@ def _write_to_single_target(self, args, extend_target_list, overwrite_target, ru
         if state.single_source_element and not state.extend:
             source_fields_values = source_fields_values.pop()
 
-        if (
-            state.extend
-            and state.overwrite
-            and not state.single_source_element
-            and not state.target_is_list
-        ):
-            add_and_overwrite(event, target_field, source_fields_values)
-            return
-
-        if (
-            state.extend
-            and not state.overwrite
-            and not state.single_source_element
-            and not state.target_is_list
-            and state.target_is_none
-        ):
-            flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
-            source_fields_values = [*flattened_source_fields]
-            add_and_overwrite(event, target_field, source_fields_values)
-            return
-
-        if (
-            state.extend
-            and not state.overwrite
-            and not state.single_source_element
-            and not state.target_is_list
-        ):
-            source_fields_values = [target_field_value, *source_fields_values]
-            add_and_overwrite(event, target_field, source_fields_values)
-            return
-
-        if (
-            state.extend
-            and not state.overwrite
-            and not state.single_source_element
-            and state.target_is_list
-        ):
-            flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
-            source_fields_values = [*target_field_value, *flattened_source_fields]
-            add_and_overwrite(event, target_field, source_fields_values)
-            return
-
-        if state.overwrite and state.extend:
-            flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
-            source_fields_values = [*flattened_source_fields]
-            add_and_overwrite(event, target_field, source_fields_values)
-            return
-
-        success = add_field_to(
-            event, target_field, source_fields_values, state.extend, state.overwrite
-        )
-        if not success:
-            raise FieldExistsWarning(rule, event, [target_field])
+        match state:
+            case State(
+                extend=True, overwrite=True, single_source_element=False, target_is_list=False
+            ):
+                add_and_overwrite(event, target_field, source_fields_values)
+                return
+
+            case State(
+                extend=True,
+                overwrite=False,
+                single_source_element=False,
+                target_is_list=False,
+                target_is_none=True,
+            ):
+                flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
+                source_fields_values = [*flattened_source_fields]
+                add_and_overwrite(event, target_field, source_fields_values)
+                return
+
+            case State(
+                extend=True, overwrite=False, single_source_element=False, target_is_list=False
+            ):
+                source_fields_values = [target_field_value, *source_fields_values]
+                add_and_overwrite(event, target_field, source_fields_values)
+                return
+
+            case State(
+                extend=True, overwrite=False, single_source_element=False, target_is_list=True
+            ):
+                flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
+                source_fields_values = [*target_field_value, *flattened_source_fields]
+                add_and_overwrite(event, target_field, source_fields_values)
+                return
+
+            case State(overwrite=True, extend=True):
+                flattened_source_fields = self._overwrite_from_source_values(source_fields_values)
+                source_fields_values = [*flattened_source_fields]
+                add_and_overwrite(event, target_field, source_fields_values)
+                return
+
+            case _:
+                success = add_field_to(
+                    event, target_field, source_fields_values, state.extend, state.overwrite
+                )
+                if not success:
+                    raise FieldExistsWarning(rule, event, [target_field])
 
     def _overwrite_from_source_values(self, source_fields_values):
         lists, not_lists = self._separate_lists_form_other_types(source_fields_values)