Refactor rule tree

[ppcad]

No description provided.

[codecov-commenter]

Codecov Report

Patch coverage: 97.59% and project coverage change: +0.11% 🎉

Comparison is base (742d1ba) 92.22% compared to head (c2140cb) 92.33%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
+ Coverage   92.22%   92.33%   +0.11%     
==========================================
  Files         133      137       +4     
  Lines        9450     9626     +176     
==========================================
+ Hits         8715     8888     +173     
- Misses        735      738       +3     

Files Changed	Coverage Δ
logprep/framework/rule_tree/rule_tree.py	91.96% <92.00%> (+1.86%)	⬆️
logprep/filter/expression/filter_expression.py	96.09% <95.23%> (-0.86%)	⬇️
logprep/framework/rule_tree/rule_parser.py	97.36% <96.42%> (-0.33%)	⬇️
logprep/framework/rule_tree/rule_segmenter.py	98.00% <98.00%> (ø)
logprep/framework/rule_tree/demorgan_resolver.py	100.00% <100.00%> (ø)
logprep/framework/rule_tree/node.py	100.00% <100.00%> (ø)
logprep/framework/rule_tree/rule_sorter.py	100.00% <100.00%> (ø)
logprep/framework/rule_tree/rule_tagger.py	100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ekneg54]

Thank you for your work. This was a lot. But I can`t merge it, because I do not understand main parts of it. please read through the comments and write me a mail. We need to come together for some pair programming sessions to get this important part of logprep right and to ensure, that we not have to touch it again in the next steps.

[ekneg54]

thank you for the changes.
plz merge if ready

[ppcad]

I had to remove __slots__ from children in FilterExpression, since this caused some rules to not match. I added a unit test for such a rule.
I don't know why __slots__ causes this.

@ekneg54
Can you please have a look at the fix?
The changes are in commit 8190857f55b39c50872d921f3e5ea8821b266947.

[ekneg54]

I'm fine with it 👍