Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and revise logprep quickstart #427

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix and revise logprep quickstart #427

merged 2 commits into from
Jul 24, 2023

Conversation

dtrai2
Copy link
Collaborator

@dtrai2 dtrai2 commented Jul 18, 2023

  • upgrade opensearch version
  • remove ports exposing and networks
  • use network_mode host (otherwise logprep couldn't connect to opensearch)
  • add kafka topic consumer on kafka start
  • fix logprep volume and entrypoint, otherwise the rules weren't loaded properly
  • add prometheus metrics to config
  • revise readme documentation

@dtrai2
fix and revise logprep quickstart
64f972d 
- upgrade opensearch version
- remove ports exposing and networks
- use network_mode host (otherwise logprep couldn't connect to opensearch)
- add kafka topic consumer on kafka start
- fix logprep volume and entrypoint, otherwise the rules weren't loaded properly
- add prometheus metrics to config
- revise readme documentation
@dtrai2 dtrai2 added the bug Something isn't working label Jul 18, 2023
@dtrai2 dtrai2 requested a review from ekneg54 July 18, 2023 12:10
@dtrai2 dtrai2 self-assigned this Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.09 🎉

Comparison is base (adfb7f0) 92.19% compared to head (765dbd4) 92.29%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   92.19%   92.29%   +0.09%     
==========================================
  Files         133      133              
  Lines        9564     9593      +29     
==========================================
+ Hits         8818     8854      +36     
+ Misses        746      739       -7

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ekneg54 ekneg54 merged commit f804d2b into main Jul 24, 2023
10 checks passed
@ekneg54 ekneg54 deleted the fix-quickstart-environment branch July 24, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekneg54 ekneg54 ekneg54 approved these changes

Assignees

@dtrai2 dtrai2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtrai2 @codecov-commenter @ekneg54